pr requested changes

packages/shared_preferences/shared_preferences_tool/lib/main.dart

@@ -9,11 +9,11 @@ import 'src/shared_preferences_state_notifier_provider.dart';
 import 'src/ui/shared_preferences_body.dart';
 
 void main() {
-  runApp(const _SharedPreferencesTools());
+  runApp(const _SharedPreferencesTool());
 }
 
-class _SharedPreferencesTools extends StatelessWidget {
-  const _SharedPreferencesTools();
+class _SharedPreferencesTool extends StatelessWidget {
+  const _SharedPreferencesTool();
 
   @override
   Widget build(BuildContext context) {

packages/shared_preferences/shared_preferences_tool/lib/src/async_state.dart

@@ -54,7 +54,7 @@ sealed class AsyncState<T> {
             other is AsyncStateData<T> && other.data == data,
           AsyncStateError<T>(
             error: final Object error,
-            stackTrace: final StackTrace? stackTrace
+            stackTrace: final StackTrace? stackTrace,
           ) =>
             other is AsyncStateError<T> &&
                 other.error == error &&
@@ -68,7 +68,7 @@ sealed class AsyncState<T> {
         AsyncStateData<T>(data: final T data) => data.hashCode,
         AsyncStateError<T>(
           error: final Object error,
-          stackTrace: final StackTrace? stackTrace
+          stackTrace: final StackTrace? stackTrace,
         ) =>
           error.hashCode ^ stackTrace.hashCode,
       };
@@ -80,7 +80,7 @@ sealed class AsyncState<T> {
       AsyncStateData<T>(data: final T data) => 'AsyncState.data($data)',
       AsyncStateError<T>(
         error: final Object error,
-        stackTrace: final StackTrace? stackTrace
+        stackTrace: final StackTrace? stackTrace,
       ) =>
         'AsyncState.error($error, $stackTrace)',
     };

packages/shared_preferences/shared_preferences_tool/lib/src/shared_preferences_state.dart

@@ -97,11 +97,15 @@ class SelectedSharedPreferencesKey {
   }
 }
 
+abstract interface class _SharedPreferencesData<T> {
+  T get value;
+}
+
 @immutable
 
 /// A class that represents the data of a shared preference in the target
 /// debug session.
-sealed class SharedPreferencesData {
+sealed class SharedPreferencesData implements _SharedPreferencesData<Object> {
   const SharedPreferencesData();
 
   const factory SharedPreferencesData.string({
@@ -127,14 +131,11 @@ sealed class SharedPreferencesData {
   /// The string representation of the value.
   String get valueAsString {
     return switch (this) {
-      final SharedPreferencesDataString data => data.value,
-      final SharedPreferencesDataInt data => data.value.toString(),
-      final SharedPreferencesDataDouble data => data.value.toString(),
-      final SharedPreferencesDataBool data => data.value.toString(),
       final SharedPreferencesDataStringList data => '\n${<String>[
           for (final (int index, String str) in data.value.indexed)
             '$index -> $str',
-        ].join('\n')}'
+        ].join('\n')}',
+      _ => '$value',
     };
   }
 
@@ -150,6 +151,7 @@ sealed class SharedPreferencesData {
   }
 
   /// Changes the value of the shared preference to the new value.
+  ///
   /// This is just a in memory change and does not affect the actual shared
   /// preference value.
   SharedPreferencesData changeValue(String newValue) {
@@ -173,30 +175,15 @@ sealed class SharedPreferencesData {
     return identical(this, other) ||
         (other is SharedPreferencesData &&
             switch (this) {
-              final SharedPreferencesDataString data =>
-                other is SharedPreferencesDataString &&
-                    other.value == data.value,
-              final SharedPreferencesDataInt data =>
-                other is SharedPreferencesDataInt && other.value == data.value,
-              final SharedPreferencesDataDouble data =>
-                other is SharedPreferencesDataDouble &&
-                    other.value == data.value,
-              final SharedPreferencesDataBool data =>
-                other is SharedPreferencesDataBool && other.value == data.value,
               final SharedPreferencesDataStringList data =>
                 other is SharedPreferencesDataStringList &&
                     listEquals(other.value, data.value),
+              _ => other.value == value,
             });
   }
 
   @override
-  int get hashCode => switch (this) {
-        final SharedPreferencesDataString data => data.value.hashCode,
-        final SharedPreferencesDataInt data => data.value.hashCode,
-        final SharedPreferencesDataDouble data => data.value.hashCode,
-        final SharedPreferencesDataBool data => data.value.hashCode,
-        final SharedPreferencesDataStringList data => data.value.hashCode,
-      };
+  int get hashCode => value.hashCode;
 
   @override
   String toString() {
@@ -211,6 +198,7 @@ class SharedPreferencesDataString extends SharedPreferencesData {
   });
 
   /// The string value of the shared preference.
+  @override
   final String value;
 }
 
@@ -221,6 +209,7 @@ class SharedPreferencesDataInt extends SharedPreferencesData {
   });
 
   /// The integer value of the shared preference.
+  @override
   final int value;
 }
 
@@ -231,6 +220,7 @@ class SharedPreferencesDataDouble extends SharedPreferencesData {
   });
 
   /// The double value of the shared preference.
+  @override
   final double value;
 }
 
@@ -241,6 +231,7 @@ class SharedPreferencesDataBool extends SharedPreferencesData {
   });
 
   /// The boolean value of the shared preference.
+  @override
   final bool value;
 }
 
@@ -251,5 +242,6 @@ class SharedPreferencesDataStringList extends SharedPreferencesData {
   });
 
   /// The list of string values of the shared preference.
+  @override
   final List<String> value;
 }

packages/shared_preferences/shared_preferences_tool/lib/src/shared_preferences_state_notifier.dart

@@ -13,6 +13,7 @@ typedef _State = AsyncState<SharedPreferencesState>;
 /// A [ValueNotifier] that manages the state of the shared preferences tool.
 class SharedPreferencesStateNotifier extends ValueNotifier<_State> {
   /// Default constructor that takes an instance of [SharedPreferencesToolEval].
+  ///
   /// You don't need to call this constructor directly. Use [SharedPreferencesStateNotifierProvider] instead.
   SharedPreferencesStateNotifier(this._eval) : super(const _State.loading());
 
@@ -21,6 +22,7 @@ class SharedPreferencesStateNotifier extends ValueNotifier<_State> {
   List<String> _keys = <String>[];
 
   /// Retrieves all keys from the shared preferences of the target debug session.
+  ///
   /// If this is called when data already exists, it will update the list of keys.
   Future<void> fetchAllKeys() async {
     value = const _State.loading();

packages/shared_preferences/shared_preferences_tool/lib/src/shared_preferences_state_notifier_provider.dart

@@ -12,6 +12,7 @@ import 'shared_preferences_tool_eval.dart';
 @visibleForTesting
 
 /// A class that provides a [SharedPreferencesStateNotifier] to its descendants.
+///
 /// Only used for testing. You can override the notifier with a mock when testing.
 class StateInheritedNotifier
     extends InheritedNotifier<SharedPreferencesStateNotifier> {
@@ -53,15 +54,15 @@ class _SharedPreferencesStateNotifierProviderState
 
   @override
   void initState() {
+    super.initState();
     final EvalOnDartLibrary eval = EvalOnDartLibrary(
       'package:shared_preferences/shared_preferences.dart',
       serviceManager.service!,
       serviceManager: serviceManager,
     );
-    final SharedPreferencesToolEval toolsEval = SharedPreferencesToolEval(eval);
-    _notifier = SharedPreferencesStateNotifier(toolsEval);
+    final SharedPreferencesToolEval toolEval = SharedPreferencesToolEval(eval);
+    _notifier = SharedPreferencesStateNotifier(toolEval);
     _notifier.fetchAllKeys();
-    super.initState();
   }
 
   @override

packages/shared_preferences/shared_preferences_tool/lib/src/shared_preferences_tool_eval.dart

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import 'package:devtools_app_shared/service.dart';
-
 import 'package:vm_service/vm_service.dart';
 
 import 'shared_preferences_state.dart';