Skip to content

[pigeon] Updates PigeonInstanceMangerApi to use the shared api channel code in Dart #6831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
May 30, 2024
Merged

[pigeon] Updates PigeonInstanceMangerApi to use the shared api channel code in Dart #6831

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
42a2bee
used shared channel code for api
bparrishMines May 29, 2024
35a4482
version bump
bparrishMines May 29, 2024
caed05e
fix extra code
bparrishMines May 29, 2024
8a281ff
test
bparrishMines May 29, 2024
1d13ee7
Merge branch 'main' of github.com:flutter/packages into pigeon_dart_i…
bparrishMines May 29, 2024
99f2aec
fix addSuffixVariable
bparrishMines May 29, 2024
c255e52
fix tests
bparrishMines May 29, 2024
54e6a6d
fix variable name
bparrishMines May 30, 2024
be50919
Merge branch 'main' of github.com:flutter/packages into pigeon_dart_i…
bparrishMines May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix variable name
  • Loading branch information
@bparrishMines
bparrishMines committed May 30, 2024
commit 54e6a6d429bd22c1af0255dbca13189785589ea9
6 changes: 4 additions & 2 deletions packages/pigeon/lib/dart_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ final BinaryMessenger? ${_varNamePrefix}binaryMessenger;
dartPackageName: dartPackageName,
);

final cb.Class proxyApi = cb.Class(
final cb.Class instanceManagerApi = cb.Class(
(cb.ClassBuilder builder) => builder
..name = '_$apiName'
..docs.add(
Expand Down Expand Up @@ -665,7 +665,9 @@ final BinaryMessenger? ${_varNamePrefix}binaryMessenger;
);

final cb.DartEmitter emitter = cb.DartEmitter(useNullSafetySyntax: true);
indent.format(DartFormatter().format('${proxyApi.accept(emitter)}'));
indent.format(
DartFormatter().format('${instanceManagerApi.accept(emitter)}'),
);
}

@override
Expand Down