Skip to content

[pigeon] Kotlin/Java method overloading for the setUp method #6843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Jun 3, 2024
Merged

[pigeon] Kotlin/Java method overloading for the setUp method #6843

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2f19ca1
Add @JvmOverloads to kotlin generation
RobinCombrink May 31, 2024
d9b0375
Version Bump
RobinCombrink May 31, 2024
cbd618b
Place the annotation in accordance with kotlin formatting
RobinCombrink Jun 1, 2024
1c3cc03
Include the `@JvmOverloads` annotation in the example app generated k…
RobinCombrink Jun 1, 2024
acac28f
Include the `@JvmOverloads` annotation in the kotlin generator unit test
RobinCombrink Jun 1, 2024
b949417
Merge branch 'main' into overload_setup
RobinCombrink Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include the @JvmOverloads annotation in the kotlin generator unit test
  • Loading branch information
@RobinCombrink
RobinCombrink committed Jun 1, 2024
commit acac28f46599adedab4be37bf81a5fe57e65da2f
4 changes: 4 additions & 0 deletions packages/pigeon/test/kotlin_generator_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,10 @@ void main() {
final String code = sink.toString();
expect(code, contains('interface Api'));
expect(code, contains('fun doSomething(input: Input): Output'));
expect(code, contains('''
@JvmOverloads
fun setUp(binaryMessenger: BinaryMessenger, api: Api?, messageChannelSuffix: String = "") {
'''));
expect(code, contains('channel.setMessageHandler'));
expect(code, contains('''
if (api != null) {
Expand Down