Skip to content

Refactor VideoPlayer to be less exposed to EventChannel & related #6908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Jun 13, 2024
Merged

Refactor VideoPlayer to be less exposed to EventChannel & related #6908

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2627784
Refactor VideoPlayer to be less reliant on channels/sinks deep within.
matanlurey Jun 11, 2024
ee4f836
Format.
matanlurey Jun 11, 2024
0334e53
++
matanlurey Jun 12, 2024
4303968
++
matanlurey Jun 12, 2024
e27eace
++
matanlurey Jun 12, 2024
f1f7581
Address feedback.
matanlurey Jun 13, 2024
d97a4ad
++
matanlurey Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
++
  • Loading branch information
@matanlurey
matanlurey committed Jun 13, 2024
commit d97a4ada59fdd1a44ee01c6d1372ff3437b839d1
22 changes: 12 additions & 10 deletions ..._player_android/android/src/test/java/io/flutter/plugins/videoplayer/VideoPlayerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,19 +314,21 @@ public void behindLiveWindowErrorResetsPlayerToDefaultPosition() {
public void otherErrorsReportVideoErrorWithErrorString() {
List<Player.Listener> listeners = new LinkedList<>();
doAnswer(invocation -> listeners.add(invocation.getArgument(0)))
.when(fakeExoPlayer)
.addListener(any());
.when(fakeExoPlayer)
.addListener(any());

@SuppressWarnings("unused")
VideoPlayer unused =
new VideoPlayer(
fakeExoPlayer,
VideoPlayerEventCallbacks.withSink(fakeEventSink),
fakeSurfaceTextureEntry,
fakeVideoPlayerOptions,
httpDataSourceFactorySpy);

PlaybackException exception = new PlaybackException("You did bad kid", null, PlaybackException.ERROR_CODE_DECODING_FAILED);
new VideoPlayer(
fakeExoPlayer,
VideoPlayerEventCallbacks.withSink(fakeEventSink),
fakeSurfaceTextureEntry,
fakeVideoPlayerOptions,
httpDataSourceFactorySpy);

PlaybackException exception =
new PlaybackException(
"You did bad kid", null, PlaybackException.ERROR_CODE_DECODING_FAILED);
listeners.forEach(listener -> listener.onPlayerError(exception));

verify(fakeEventSink).error(eq("VideoError"), contains("You did bad kid"), any());
Expand Down