Skip to content

[pigeon] Fully-qualify types in Equatable extension test #6946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Jun 18, 2024
Merged

[pigeon] Fully-qualify types in Equatable extension test #6946

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5289f8e
[pigeon] Fully-quality types in Equatable extension test
jmagman Jun 18, 2024
b6cdacc
CHANGELOG
jmagman Jun 18, 2024
7157d8e
CHANGELOG
jmagman Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/pigeon/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## NEXT
* Fully-qualifies types in Equatable extension test.
Copy link
Contributor

@LouiseHsu LouiseHsu Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should maybe add [swift] to the beginning of this!

Copy link
Contributor

@tarrinneal tarrinneal Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and a new line after the ## NEXT line.

Copy link
Member Author

@jmagman jmagman Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to "[swift] Fully-qualifies types in Equatable extension test."


## 20.0.1

* [cpp] Fixes handling of null class arguments.
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/platform_tests/test_plugin/example/ios/Runner/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import Flutter
import UIKit

@UIApplicationMain
@main
Copy link
Member Author

@jmagman jmagman Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the extension error. The Flutter tool updated this when I built the example.

@objc class AppDelegate: FlutterAppDelegate {
override func application(
_ application: UIApplication,
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/EnumTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class MockEnumApi2Host: EnumApi2Host {
}
}

extension DataWithEnum: Equatable {
extension test_plugin.DataWithEnum: Swift.Equatable {
public static func == (lhs: DataWithEnum, rhs: DataWithEnum) -> Bool {
lhs.state == rhs.state
}
Expand Down