Skip to content

[shared_preferences] Platform implementations of async api #6965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 23 commits into from
Jul 30, 2024
Merged

[shared_preferences] Platform implementations of async api #6965

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
0b619b4
plat
tarrinneal Jul 18, 2024
b8b4643
analyze
tarrinneal Jul 18, 2024
3216359
newer version
tarrinneal Jul 18, 2024
351e189
revert gradle changes
tarrinneal Jul 18, 2024
167a191
revert gradle wrapper
tarrinneal Jul 19, 2024
751b7ab
gradle
tarrinneal Jul 19, 2024
966cc82
bom
tarrinneal Jul 19, 2024
f5a7965
move bom
tarrinneal Jul 19, 2024
6d2127b
new kotlin version
tarrinneal Jul 20, 2024
5e80acb
rename classes and files
tarrinneal Jul 22, 2024
6a148c4
legacy
tarrinneal Jul 22, 2024
f3002f1
more legacy
tarrinneal Jul 22, 2024
48a294f
one more legacy
tarrinneal Jul 23, 2024
9d4ce28
anotha one
tarrinneal Jul 23, 2024
2b7b3a6
fix tests
tarrinneal Jul 23, 2024
fa7389d
revert test fix, fix real issue
tarrinneal Jul 23, 2024
bc85c30
fix explode
tarrinneal Jul 24, 2024
9780d68
format
tarrinneal Jul 24, 2024
9249648
revert kotlin version, update changelog
tarrinneal Jul 25, 2024
475237f
bom
tarrinneal Jul 26, 2024
94498a0
Merge branch 'main' of github.com:flutter/packages into spr-plat
tarrinneal Jul 26, 2024
78ace3a
move bom
tarrinneal Jul 26, 2024
89ed80a
kotlin version, how do they work?
tarrinneal Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
legacy
  • Loading branch information
@tarrinneal
tarrinneal committed Jul 22, 2024
commit 6a148c4ab602854e594a98662b7ccac72f66d536
12 changes: 6 additions & 6 deletions packages/shared_preferences/shared_preferences_foundation/darwin/Tests/RunnerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ class RunnerTests: XCTestCase {
let testKeyTwo = "baz"
let testValue = "bar"

// Deprecated system tests.
// Legacy system tests.

let prefixes: [String] = ["aPrefix", ""]

func testSetAndGet() throws {
for aPrefix in prefixes {
let plugin = DeprecatedSharedPreferencesPlugin()
let plugin = LegacySharedPreferencesPlugin()

plugin.setBool(key: "\(aPrefix)aBool", value: true)
plugin.setDouble(key: "\(aPrefix)aDouble", value: 3.14)
Expand All @@ -42,7 +42,7 @@ class RunnerTests: XCTestCase {

func testGetWithAllowList() throws {
for aPrefix in prefixes {
let plugin = DeprecatedSharedPreferencesPlugin()
let plugin = LegacySharedPreferencesPlugin()

plugin.setBool(key: "\(aPrefix)aBool", value: true)
plugin.setDouble(key: "\(aPrefix)aDouble", value: 3.14)
Expand All @@ -61,7 +61,7 @@ class RunnerTests: XCTestCase {

func testRemove() throws {
for aPrefix in prefixes {
let plugin = DeprecatedSharedPreferencesPlugin()
let plugin = LegacySharedPreferencesPlugin()
let testKey = "\(aPrefix)\(testKey)"
plugin.setValue(key: testKey, value: 42)

Expand All @@ -79,7 +79,7 @@ class RunnerTests: XCTestCase {

func testClearWithNoAllowlist() throws {
for aPrefix in prefixes {
let plugin = DeprecatedSharedPreferencesPlugin()
let plugin = LegacySharedPreferencesPlugin()
let testKey = "\(aPrefix)\(testKey)"
plugin.setValue(key: testKey, value: 42)

Expand All @@ -97,7 +97,7 @@ class RunnerTests: XCTestCase {

func testClearWithAllowlist() throws {
for aPrefix in prefixes {
let plugin = DeprecatedSharedPreferencesPlugin()
let plugin = LegacySharedPreferencesPlugin()
let testKey = "\(aPrefix)\(testKey)"
plugin.setValue(key: testKey, value: 42)

Expand Down
8 changes: 4 additions & 4 deletions ...references_foundation/Sources/shared_preferences_foundation/SharedPreferencesPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@ import Foundation

let argumentError: String = "Argument Error"

public class DeprecatedSharedPreferencesPlugin: NSObject, FlutterPlugin, DeprecatedUserDefaultsApi {
public class LegacySharedPreferencesPlugin: NSObject, FlutterPlugin, LegacyUserDefaultsApi {

public static func register(with registrar: FlutterPluginRegistrar) {
let instance = DeprecatedSharedPreferencesPlugin()
let instance = LegacySharedPreferencesPlugin()
// Workaround for https://github.com/flutter/flutter/issues/118103.
#if os(iOS)
let messenger = registrar.messenger()
#else
let messenger = registrar.messenger
#endif
DeprecatedUserDefaultsApiSetup.setUp(binaryMessenger: messenger, api: instance)
LegacyUserDefaultsApiSetup.setUp(binaryMessenger: messenger, api: instance)
}

func getAll(prefix: String, allowList: [String]?) -> [String?: Any?] {
Expand Down Expand Up @@ -81,7 +81,7 @@ public class SharedPreferencesPlugin: NSObject, FlutterPlugin, UserDefaultsApi {
let messenger = registrar.messenger
#endif
UserDefaultsApiSetup.setUp(binaryMessenger: messenger, api: instance)
DeprecatedSharedPreferencesPlugin.register(with: registrar)
LegacySharedPreferencesPlugin.register(with: registrar)
}

static private func getUserDefaults(options: SharedPreferencesPigeonOptions) throws
Expand Down