Skip to content

[pigeon] Implement equals for Java data classes #6992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Jun 27, 2024
Merged

[pigeon] Implement equals for Java data classes #6992

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
adac27b
Add generation of equals/hashCode
stuartmorgan-g Jun 26, 2024
62590d0
Update generated output
stuartmorgan-g Jun 26, 2024
e3c06e8
Add native unit testing, and fix array handling
stuartmorgan-g Jun 26, 2024
d8f1bbb
Generate
stuartmorgan-g Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Generate
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Jun 26, 2024
commit d8f1bbb6095826cbe14d4f828df9466d10523fa3
21 changes: 21 additions & 0 deletions packages/pigeon/example/app/android/app/src/main/java/io/flutter/plugins/Messages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Objects;

/** Generated class from Pigeon. */
@SuppressWarnings({"unused", "unchecked", "CodeBlock2Expr", "RedundantSuppression", "serial"})
Expand Down Expand Up @@ -132,6 +133,26 @@ public void setData(@NonNull Map<String, String> setterArg) {
/** Constructor is non-public to enforce null safety; use Builder. */
MessageData() {}

@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass()) {
return false;
}
MessageData that = (MessageData) o;
return Objects.equals(name, that.name)
&& Objects.equals(description, that.description)
&& code.equals(that.code)
&& data.equals(that.data);
}

@Override
public int hashCode() {
return Objects.hash(name, description, code, data);
}

public static final class Builder {

private @Nullable String name;
Expand Down