Fix unintentional change to Palette, avoid abbreviations, real hash c…

…ode impl

packages/multicast_dns/example/main.dart

@@ -16,13 +16,13 @@ void main() async {
   await client.start();
 
   // Get the PTR recod for the service.
-  await for (PtrResourceRecord ptr in client.lookup(RRType.ptr, name)) {
+  await for (PtrResourceRecord ptr in client.lookup(ResourceRecordType.ptr, name)) {
     // Use the domainName from the PTR record to get the SRV record,
     // which will have the port and local hostname.
     // Note that duplicate messages may come through, especially if any
     // other mDNS queries are running elsewhere on the machine.
     await for (SrvResourceRecord srv
-        in client.lookup(RRType.srv, ptr.domainName)) {
+        in client.lookup(ResourceRecordType.srv, ptr.domainName)) {
       // Domain name will be something like "[email protected]._dartobservatory._tcp.local"
       final String bundleId =
           ptr.domainName.substring(0, ptr.domainName.indexOf('@'));

packages/multicast_dns/example/mdns-resolve.dart

@@ -30,12 +30,12 @@ For example:
   await client.start();
   final Duration timeout = Duration(seconds: int.parse(arguments['timeout']));
   await for (IPAddressResourceRecord record
-      in client.lookup(RRType.a, name, timeout: timeout)) {
+      in client.lookup(ResourceRecordType.a, name, timeout: timeout)) {
     print('Found address (${record.address}).');
   }
 
   await for (IPAddressResourceRecord record
-      in client.lookup(RRType.aaaa, name, timeout: timeout)) {
+      in client.lookup(ResourceRecordType.aaaa, name, timeout: timeout)) {
     print('Found address (${record.address}).');
   }
   client.stop();

packages/multicast_dns/example/mdns-sd.dart

@@ -30,28 +30,28 @@ For example:
   final MDnsClient client = MDnsClient();
   await client.start();
 
-  await for (PtrResourceRecord ptr in client.lookup(RRType.ptr, name)) {
+  await for (PtrResourceRecord ptr in client.lookup(ResourceRecordType.ptr, name)) {
     if (verbose) {
       print(ptr);
     }
     await for (SrvResourceRecord srv
-        in client.lookup(RRType.srv, ptr.domainName)) {
+        in client.lookup(ResourceRecordType.srv, ptr.domainName)) {
       if (verbose) {
         print(srv);
       }
       if (verbose) {
-        await client.lookup(RRType.txt, ptr.domainName).forEach(print);
+        await client.lookup(ResourceRecordType.txt, ptr.domainName).forEach(print);
       }
       await for (IPAddressResourceRecord ip
-          in client.lookup(RRType.a, srv.target)) {
+          in client.lookup(ResourceRecordType.a, srv.target)) {
         if (verbose) {
           print(ip);
         }
         print(
             'Service instance found at ${srv.target}:${srv.port} with ${ip.address}.');
       }
       await for (IPAddressResourceRecord ip
-          in client.lookup(RRType.aaaa, srv.target)) {
+          in client.lookup(ResourceRecordType.aaaa, srv.target)) {
         if (verbose) {
           print(ip);
         }

packages/multicast_dns/lib/mdns_client.dart

@@ -128,7 +128,7 @@ class MDnsClient {
 
   /// Lookup a [ResourceRecord], potentially from cache.
   ///
-  /// The [type] parameter must be a valid [RRType].  The [name] parameter is
+  /// The [type] parameter must be a valid [ResourceRecordType].  The [name] parameter is
   /// the name of the service to lookup, and must not be null.  The [timeout]
   /// parameter specifies how long the intenral cache should hold on to the
   /// record.  The [multicast] parameter specifies whether the query should be
@@ -142,7 +142,7 @@ class MDnsClient {
     Duration timeout = const Duration(seconds: 5),
     bool multicast = true,
   }) {
-    RRType.debugAssertValid(type);
+    ResourceRecordType.debugAssertValid(type);
     assert(multicast != null);
     assert(name != null);
 

packages/multicast_dns/lib/src/constants.dart

@@ -14,13 +14,21 @@ InternetAddress mDnsAddressIPv6 = InternetAddress('FF02::FB');
 const int mDnsPort = 5353;
 
 /// Enumeration of supported resource record class types.
-class RRClass {
+class ResourceRecordClass {
+  // This class is intended to be used as a namespace, and should not be
+  // extended directly.
+  factory ResourceRecordClass._() => null;
+
   /// Internet address class ("IN").
   static const int internet = 1;
 }
 
 /// Enumeration of DNS question types.
 class QuestionType {
+  // This class is intended to be used as a namespace, and should not be
+  // extended directly.
+  factory QuestionType._() => null;
+
   /// "QU" Question.
   static const int unicast = 0x8000;
 

packages/multicast_dns/lib/src/lookup_resolver.dart

@@ -12,7 +12,7 @@ class PendingRequest extends LinkedListEntry<PendingRequest> {
   /// Creates a new PendingRequest.
   PendingRequest(this.type, this.name, this.controller);
 
-  /// The [RRType] of the request.
+  /// The [ResourceRecordType] of the request.
   final int type;
 
   /// The domain name.

packages/multicast_dns/lib/src/native_protocol_client.dart

@@ -53,7 +53,7 @@ class ResourceRecordCache {
 
   /// Get a record from this cache.
   void lookup(String name, int type, List<ResourceRecord> results) {
-    RRType.debugAssertValid(type);
+    ResourceRecordType.debugAssertValid(type);
     final int time = DateTime.now().millisecondsSinceEpoch;
     for (int i = _position + size; i >= _position; i--) {
       final int index = i % size;

packages/multicast_dns/lib/src/packet.dart

@@ -36,15 +36,15 @@ List<String> processDnsNameParts(String name) {
 
 /// Encode an mDNS query packet.
 ///
-/// The [type] parameter must be a valid [RRType] value. The [multicast] parameter
+/// The [type] parameter must be a valid [ResourceRecordType] value. The [multicast] parameter
 /// must not be null.
 List<int> encodeMDnsQuery(
   String name, {
-  int type = RRType.a,
+  int type = ResourceRecordType.a,
   bool multicast = true,
 }) {
   assert(name != null);
-  RRType.debugAssertValid(type);
+  ResourceRecordType.debugAssertValid(type);
   assert(multicast != null);
 
   final List<String> nameParts = processDnsNameParts(name);
@@ -86,7 +86,7 @@ List<int> encodeMDnsQuery(
   offset += 2;
   bd.setUint16(
       offset,
-      RRClass.internet |
+      ResourceRecordClass.internet |
           (multicast ? QuestionType.multicast : QuestionType.unicast));
 
   return data;
@@ -179,15 +179,15 @@ List<ResourceRecord> decodeMDnsResponse(List<int> packet) {
 
   final Uint8List data =
       packet is Uint8List ? packet : Uint8List.fromList(packet);
-  final ByteData bd = ByteData.view(data.buffer);
+  final ByteData packetBytes = ByteData.view(data.buffer);
   // Number of answers.
-  final int ancount = bd.getUint16(_kAncountOffset);
+  final int ancount = packetBytes.getUint16(_kAncountOffset);
   if (ancount == 0) {
     return null;
   }
 
   // Number of resource records.
-  final int arcount = bd.getUint16(_kArcountOffset);
+  final int arcount = packetBytes.getUint16(_kArcountOffset);
   int offset = _kHeaderSize;
 
   void checkLength(int required) {
@@ -198,72 +198,72 @@ List<ResourceRecord> decodeMDnsResponse(List<int> packet) {
 
   ResourceRecord readResourceRecord() {
     // First read the FQDN.
-    final _FQDNReadResult result = _readFQDN(data, bd, offset, length);
+    final _FQDNReadResult result = _readFQDN(data, packetBytes, offset, length);
     final String fqdn = result.fqdn;
     offset += result.bytesRead;
     checkLength(offset + 2);
-    final int type = bd.getUint16(offset);
+    final int type = packetBytes.getUint16(offset);
     offset += 2;
     // The first bit of the rrclass field is set to indicate that the answer is
     // unique and the querier should flush the cached answer for this name
     // (RFC 6762, Sec. 10.2). We ignore it for now since we don't cache answers.
     checkLength(offset + 2);
-    final int cls = bd.getUint16(offset) & 0x7fff;
+    final int resourceRecordClass = packetBytes.getUint16(offset) & 0x7fff;
 
-    if (cls != RRClass.internet) {
+    if (resourceRecordClass != ResourceRecordClass.internet) {
       // We do not support other classes.
       return null;
     }
 
     offset += 2;
     checkLength(offset + 4);
-    final int ttl = bd.getInt32(offset);
+    final int ttl = packetBytes.getInt32(offset);
     offset += 4;
 
     checkLength(offset + 2);
-    final int rDataLength = bd.getUint16(offset);
+    final int rDataLength = packetBytes.getUint16(offset);
     offset += 2;
     final int validUntil = DateTime.now().millisecondsSinceEpoch + ttl * 1000;
     switch (type) {
-      case RRType.a:
+      case ResourceRecordType.a:
         checkLength(offset + rDataLength);
         final StringBuffer addr = StringBuffer();
         final int stop = offset + rDataLength;
-        addr.write(bd.getUint8(offset));
+        addr.write(packetBytes.getUint8(offset));
         offset++;
         for (offset; offset < stop; offset++) {
           addr.write('.');
-          addr.write(bd.getUint8(offset));
+          addr.write(packetBytes.getUint8(offset));
         }
         return IPAddressResourceRecord(fqdn, validUntil,
             address: InternetAddress(addr.toString()));
-      case RRType.aaaa:
+      case ResourceRecordType.aaaa:
         checkLength(offset + rDataLength);
-
         final StringBuffer addr = StringBuffer();
         final int stop = offset + rDataLength;
-        addr.write(bd.getUint16(offset).toRadixString(16));
+        addr.write(packetBytes.getUint16(offset).toRadixString(16));
         offset += 2;
         for (offset; offset < stop; offset += 2) {
           addr.write(':');
-          addr.write(bd.getUint16(offset).toRadixString(16));
+          addr.write(packetBytes.getUint16(offset).toRadixString(16));
         }
         return IPAddressResourceRecord(
           fqdn,
           validUntil,
           address: InternetAddress(addr.toString()),
         );
-      case RRType.srv:
+      case ResourceRecordType.srv:
         checkLength(offset + 2);
-        final int priority = bd.getUint16(offset);
+        final int priority = packetBytes.getUint16(offset);
         offset += 2;
         checkLength(offset + 2);
-        final int weight = bd.getUint16(offset);
+        final int weight = packetBytes.getUint16(offset);
         offset += 2;
         checkLength(offset + 2);
-        final int port = bd.getUint16(offset);
+        final int port = packetBytes.getUint16(offset);
         offset += 2;
-        final _FQDNReadResult result = _readFQDN(data, bd, offset, length);
+        final _FQDNReadResult result =
+            _readFQDN(data, packetBytes, offset, length);
         offset += result.bytesRead;
         return SrvResourceRecord(
           fqdn,
@@ -274,16 +274,17 @@ List<ResourceRecord> decodeMDnsResponse(List<int> packet) {
           weight: weight,
         );
         break;
-      case RRType.ptr:
+      case ResourceRecordType.ptr:
         checkLength(offset + rDataLength);
-        final _FQDNReadResult result = _readFQDN(data, bd, offset, length);
+        final _FQDNReadResult result =
+            _readFQDN(data, packetBytes, offset, length);
         offset += rDataLength;
         return PtrResourceRecord(
           fqdn,
           validUntil,
           domainName: result.fqdn,
         );
-      case RRType.txt:
+      case ResourceRecordType.txt:
         checkLength(offset + rDataLength);
         final Uint8List rawText = Uint8List.view(
           data.buffer,