Skip to content

[camera_avfoundation] fix stopVideoRecording waiting indefinitely and video lag at start #7065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
Aug 2, 2024
Merged

[camera_avfoundation] fix stopVideoRecording waiting indefinitely and video lag at start #7065

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ba64f20
fix stopVideoRecording waiting indefinitely and video lag at start
misos1 Jul 7, 2024
e2161c3
rename variable
misos1 Jul 9, 2024
f2d83af
Merge branch 'main' into startwriting_in_startrecording
misos1 Jul 10, 2024
165afc7
Merge branch 'main' into startwriting_in_startrecording
misos1 Jul 11, 2024
05d19ce
Merge branch 'main' into startwriting_in_startrecording
misos1 Jul 12, 2024
0bfce88
rename variable and change comments
misos1 Jul 17, 2024
1591697
Merge branch 'main' into startwriting_in_startrecording
misos1 Jul 17, 2024
172b3bf
change comment
misos1 Jul 17, 2024
fb3d713
fix test
misos1 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test
  • Loading branch information
@misos1
misos1 committed Jul 22, 2024
commit fb3d713b6dbd5217426d8fe25e285a73d7af4114
5 changes: 5 additions & 0 deletions packages/camera/camera_avfoundation/example/ios/RunnerTests/FLTCamSampleBufferTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,11 @@ - (void)testStartWritingShouldNotBeCalledBetweenSampleCreationAndAppending {
videoAppended = YES;
});

id inputMock = OCMClassMock([AVAssetWriterInput class]);
OCMStub([inputMock assetWriterInputWithMediaType:OCMOCK_ANY outputSettings:OCMOCK_ANY])
.andReturn(inputMock);
OCMStub([inputMock isReadyForMoreMediaData]).andReturn(YES);

[cam
startVideoRecordingWithCompletion:^(FlutterError *_Nullable error) {
}
Expand Down