Skip to content

[in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift #7171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LouiseHsu merged 8 commits into from
Jul 18, 2024
Merged

[in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift #7171

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
43a60a5
init
LouiseHsu Jul 18, 2024
0f08af5
symlinks
LouiseHsu Jul 18, 2024
80b6596
Merge branch 'main' into iap-tests-paymentqueueDelete
LouiseHsu Jul 18, 2024
dbcfc3d
update availability
LouiseHsu Jul 18, 2024
7defccb
Merge branch 'iap-tests-paymentqueueDelete' of github.com:LouiseHsu/p…
LouiseHsu Jul 18, 2024
93b83cf
rename tests
LouiseHsu Jul 18, 2024
082cb01
versioning
LouiseHsu Jul 18, 2024
656df10
.
LouiseHsu Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update availability
  • Loading branch information
@LouiseHsu
LouiseHsu committed Jul 18, 2024
commit dbcfc3d7f832d3f3b1af8a2a05e31e44b73bc1eb
4 changes: 2 additions & 2 deletions packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/FIAPPaymentQueueDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@

NS_ASSUME_NONNULL_BEGIN

API_AVAILABLE(ios(13))
API_UNAVAILABLE(tvos, macos, watchos)
API_AVAILABLE(ios(13), macos(10.15))
Copy link
Contributor Author

@LouiseHsu LouiseHsu Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should've always been here. When mac support first got added i think this got missed here
For some reason the objc macos tests still ran fine even though it was using FIAPPaymentQueueDelegate which was technically unavailable, but when i rewrote the tests in swift, the compiler complained.
Adding this should be fine as its a wrapper over SKPaymentQueueDelegate and mac is supported

API_UNAVAILABLE(tvos, watchos)
@interface FIAPPaymentQueueDelegate : NSObject <SKPaymentQueueDelegate>
- (id)initWithMethodChannel:(id<FLTMethodChannelProtocol>)methodChannel;
@end
Expand Down