Skip to content

[video_player_avfoundation] send video load failure even when eventsink was initialized late #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 10 commits into from
Nov 20, 2024
Merged

[video_player_avfoundation] send video load failure even when eventsink was initialized late #7194

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
16d3d7a
send video load failure even when eventsink was initialized late
misos1 Jul 16, 2024
12a061e
move dispatch_async and change comments
misos1 Aug 15, 2024
902c3e6
Merge branch 'main' into complete_on_error
misos1 Aug 15, 2024
4ab3c53
add braces
misos1 Aug 15, 2024
1e0964f
rename function
misos1 Aug 20, 2024
89db486
move failure check outside
misos1 Aug 20, 2024
1a6fd6f
prefer to use error from tracks loading
misos1 Oct 17, 2024
60330dc
fix format
misos1 Oct 17, 2024
01b21ac
Merge branch 'main' into complete_on_error
misos1 Oct 17, 2024
ab57c33
fix format
misos1 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix format
  • Loading branch information
@misos1
misos1 committed Oct 17, 2024
commit 60330dc4dec16aed60bdc9a8a3dbdf59534d8d2a
2 changes: 1 addition & 1 deletion packages/video_player/video_player_avfoundation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 2.6.2
## 2.6.3

* Fixes VideoPlayerController.initialize() future never resolving with invalid video file.
* Adds more details to the error message returned by VideoPlayerController.initialize().
Expand Down
6 changes: 4 additions & 2 deletions ...darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,10 +406,12 @@ - (void)sendFailedToLoadVideoEvent {
}
// Prefer more detailed error information from tracks loading.
NSError *error;
if ([self.player.currentItem.asset statusOfValueForKey:@"tracks" error:&error] != AVKeyValueStatusFailed) {
if ([self.player.currentItem.asset statusOfValueForKey:@"tracks"
error:&error] != AVKeyValueStatusFailed) {
error = self.player.currentItem.error;
}
__block NSMutableOrderedSet<NSString*> *details = [NSMutableOrderedSet orderedSetWithObject:@"Failed to load video"];
__block NSMutableOrderedSet<NSString*> *details =
[NSMutableOrderedSet orderedSetWithObject:@"Failed to load video"];
void (^add)(NSString *) = ^(NSString *detail) {
if (detail != nil) {
[details addObject:detail];
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player_avfoundation/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_avfoundation
description: iOS and macOS implementation of the video_player plugin.
repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player_avfoundation
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.6.2
version: 2.6.3

environment:
sdk: ^3.3.0
Expand Down