[camera_avfoundation] dealloc camera on dispose #7211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM
@hellohuanlin for secondary review
bparrishMines
approved these changes
Jul 30, 2024
hellohuanlin
approved these changes
Aug 2, 2024
bparrishMines
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/7211, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
bparrishMines
added
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/7211, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 5, 2024
flutter/packages@cc9ff47...82e8d1e 2024-08-04 [email protected] Manual roll Flutter from f10a497 to cbfb222 (23 revisions) (flutter/packages#7298) 2024-08-04 [email protected] [camera_avfoundation] dealloc camera on dispose (flutter/packages#7211) 2024-08-03 [email protected] Manual roll Flutter from 4ff9462 to f10a497 (22 revisions) (flutter/packages#7297) 2024-08-03 [email protected] Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions) (flutter/packages#7296) 2024-08-03 [email protected] Manual roll Flutter from 9d5ede0 to 85960d2 (24 revisions) (flutter/packages#7295) 2024-08-02 [email protected] Roll to 9d5ede0, disabling impeller for google_maps_flutter_android (flutter/packages#7294) 2024-08-02 [email protected] [camera_avfoundation] fix stopVideoRecording waiting indefinitely and video lag at start (flutter/packages#7065) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@cc9ff47...82e8d1e 2024-08-04 [email protected] Manual roll Flutter from f10a497 to cbfb222 (23 revisions) (flutter/packages#7298) 2024-08-04 [email protected] [camera_avfoundation] dealloc camera on dispose (flutter/packages#7211) 2024-08-03 [email protected] Manual roll Flutter from 4ff9462 to f10a497 (22 revisions) (flutter/packages#7297) 2024-08-03 [email protected] Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions) (flutter/packages#7296) 2024-08-03 [email protected] Manual roll Flutter from 9d5ede0 to 85960d2 (24 revisions) (flutter/packages#7295) 2024-08-02 [email protected] Roll to 9d5ede0, disabling impeller for google_maps_flutter_android (flutter/packages#7294) 2024-08-02 [email protected] [camera_avfoundation] fix stopVideoRecording waiting indefinitely and video lag at start (flutter/packages#7065) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@cc9ff47...82e8d1e 2024-08-04 [email protected] Manual roll Flutter from f10a497 to cbfb222 (23 revisions) (flutter/packages#7298) 2024-08-04 [email protected] [camera_avfoundation] dealloc camera on dispose (flutter/packages#7211) 2024-08-03 [email protected] Manual roll Flutter from 4ff9462 to f10a497 (22 revisions) (flutter/packages#7297) 2024-08-03 [email protected] Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions) (flutter/packages#7296) 2024-08-03 [email protected] Manual roll Flutter from 9d5ede0 to 85960d2 (24 revisions) (flutter/packages#7295) 2024-08-02 [email protected] Roll to 9d5ede0, disabling impeller for google_maps_flutter_android (flutter/packages#7294) 2024-08-02 [email protected] [camera_avfoundation] fix stopVideoRecording waiting indefinitely and video lag at start (flutter/packages#7065) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When is camera disposed in
disposeCamerait callscloseand leaves_camerauntouched so after another call tosessionQueueCreateCameraWithNameit callsclosesecond time and only here is_cameradisposed by assigning new value into that variable. Callingclose2x may be unexpected and prone to later errors if someone adds here something which expects that it will be called only once. Also having dangling_cameraafter dispose (without creating new one) can have other unintended consequences although maybe benign for now. For example there is[_motionManager stopAccelerometerUpdates]which is called only indealloc.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.