Skip to content

[url_launcher] launchUrl always returns true for valid schemes on the web. #7229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Aug 6, 2024
Merged

[url_launcher] launchUrl always returns true for valid schemes on the web. #7229

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0c29f94
[url_launcher] Prevent launchUrl from incorrectly returning false on web
Frank3K Jul 28, 2024
7937f40
Merge remote-tracking branch 'origin/main' into url-launcher-issue-13…
Frank3K Aug 3, 2024
4764f5e
[url_launcher] Always return true for launchUrl, except for disallowe…
Frank3K Aug 3, 2024
36b1437
[url_launcher] Add test for unknown scheme
Frank3K Aug 3, 2024
ba2b3d5
dart format .
ditman Aug 5, 2024
e057a58
Slight rewrite of the CHANGELOG.md
ditman Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dart format .
  • Loading branch information
@ditman
ditman committed Aug 5, 2024
commit ba2b3d5a7ad9dd0d5f29c412c895da048ecf1e80
5 changes: 3 additions & 2 deletions packages/url_launcher/url_launcher_web/example/integration_test/url_launcher_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,14 @@ void main() {
expect(plugin.launch('javascript:alert("1")'), completion(isFalse));
});

testWidgets('launching a unknown sceheme returns true', (WidgetTester _) async {
testWidgets('launching a unknown sceheme returns true',
(WidgetTester _) async {
expect(
plugin.launch(
'foo:bar',
),
completion(isTrue));
});
});
});

group('openNewWindow', () {
Expand Down