Skip to content

[camera_avfoundation] enable more than 30 fps #7394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 14 commits into from
Nov 5, 2024
Merged

[camera_avfoundation] enable more than 30 fps #7394

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6c769f9
enable more than 30 fps
misos1 Aug 7, 2024
4920305
Merge branch 'main' into more_fps
misos1 Aug 14, 2024
4f1483f
correctly set _previewSize
misos1 Aug 15, 2024
6c210c9
Merge branch 'main' into more_fps
misos1 Aug 21, 2024
30a4856
split camera changes from more_fps
misos1 Aug 21, 2024
5e1f249
extract format selection into function and more
misos1 Sep 5, 2024
5007358
revert reordering lockDevice with beginConfigurationForSession
misos1 Sep 5, 2024
65f8113
fix format
misos1 Sep 5, 2024
27868df
fix format
misos1 Sep 5, 2024
3983273
add comments and small changes
misos1 Sep 19, 2024
1d8f05a
fix format
misos1 Sep 19, 2024
cc632ec
change comments
misos1 Oct 12, 2024
f36d2dd
Merge branch 'main' into more_fps
misos1 Oct 12, 2024
0125d77
change activeFormat always if framesPerSecond is set
misos1 Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into more_fps
  • Loading branch information
@misos1
misos1 authored Aug 14, 2024
commit 492030518f71a4837389fe55cee66183fac9c295
11 changes: 10 additions & 1 deletion packages/camera/camera_avfoundation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
## 0.9.17+2
## 0.9.17+4

* Adds possibility to use any supported FPS and fixes crash when using unsupported FPS.
Copy link
Contributor

@hellohuanlin hellohuanlin Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Adds ability to...

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the new test that triggers the codepath that used to crash?

Copy link
Contributor Author

@misos1 misos1 Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the real captureDevice.activeVideoMinFrameDuration (or ...Max...) is set to value outside of what is supported by active format it immediately throws an objc exception. For tests, mocked wrappers are used so this cannot be triggered. But the test testSettings_ShouldSelectFormatWhichSupports60FPS tries to set 60 fps which actually triggered this crash on my device for media presets other than 1280x720.

* Updates minimum supported SDK version to Flutter 3.19/Dart 3.3.

## 0.9.17+3

* Fixes deallocation of camera on dispose.

## 0.9.17+2

* Fixes stopVideoRecording waiting indefinitely and lag at start of video.

## 0.9.17+1

Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_avfoundation/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera_avfoundation
description: iOS implementation of the camera plugin.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_avfoundation
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.9.17+2
version: 0.9.17+4

environment:
sdk: ^3.3.0
Expand Down
1 change: 1 addition & 0 deletions packages/video_player/video_player_avfoundation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Adds possibility to play videos at more than 30 FPS.
* Fixes playing state not updating in some paths.
* Updates minimum supported SDK version to Flutter 3.19/Dart 3.3.

## 2.6.1

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.