Skip to content

[camera_windows] Set device media type for video preview explicitly #7447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 8 commits into from
Nov 13, 2024
Merged

[camera_windows] Set device media type for video preview explicitly #7447

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b79eea5
Set device media type for video preview explicitly
dasyad00 Aug 19, 2024
d887b8f
Bump camera_windows version and document changes
dasyad00 Aug 19, 2024
b01c17c
Verify usage of SetCurrentDeviceMediaType
dasyad00 Aug 21, 2024
1f17a42
Move SetCurrentDeviceMediaType to StartPreview
dasyad00 Oct 31, 2024
cdf4f5c
Fix file formatting
dasyad00 Oct 31, 2024
2445b24
Rename overloaded function with suffix
dasyad00 Nov 13, 2024
923fc4d
Clarify error messages for StartPreview
dasyad00 Nov 13, 2024
74cbd43
Typo fix
stuartmorgan-g Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify error messages for StartPreview
  • Loading branch information
@dasyad00
dasyad00 committed Nov 13, 2024
commit 923fc4d7ffb0c55c698bc2a125bfc016482d4e59
4 changes: 2 additions & 2 deletions packages/camera/camera_windows/windows/capture_controller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ void CaptureControllerImpl::StartPreview() {
hr = capture_engine_->GetSource(&source);
if (FAILED(hr)) {
return OnPreviewStarted(GetCameraResult(hr),
"Failed to initialize video preview");
"Failed to get capture engine source");
}

if (!base_preview_media_type_) {
Expand All @@ -592,7 +592,7 @@ void CaptureControllerImpl::StartPreview() {
base_preview_media_type_.Get());
if (FAILED(hr)) {
return OnPreviewStarted(GetCameraResult(hr),
"Failed to initialize video preview");
"Failed to set video preview output format");
}

texture_handler_->UpdateTextureSize(preview_frame_width_,
Expand Down