Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
b126a15
pigeon stuff
LouiseHsu Sep 3, 2024
ae9095a
refactored AND working heh
LouiseHsu Sep 4, 2024
c38b66f
format
LouiseHsu Sep 4, 2024
268a50e
pre refactor for cache
LouiseHsu Sep 4, 2024
f6ec07a
.
LouiseHsu Sep 4, 2024
aa36dfd
fix configuration file
LouiseHsu Sep 5, 2024
8724d40
more docs
LouiseHsu Sep 5, 2024
a6cbd98
more docs and clean up
LouiseHsu Sep 5, 2024
b75eec7
.
LouiseHsu Sep 13, 2024
4d2fd59
FIXED TESTING ISSUE
LouiseHsu Sep 24, 2024
aeef979
native tests are donesies
LouiseHsu Sep 25, 2024
acf499f
moreeee clean up and tests,
LouiseHsu Sep 26, 2024
c3c7204
format, comments, remove prints
LouiseHsu Sep 26, 2024
9021b6f
versioning, analyze
LouiseHsu Sep 26, 2024
666df56
symlink the test files
LouiseHsu Sep 26, 2024
97b746f
fix mac cant build
LouiseHsu Sep 26, 2024
add5bf5
podspec, licensing
LouiseHsu Sep 26, 2024
06b42d0
.
LouiseHsu Sep 27, 2024
0701d2a
remove any to get around old linter
LouiseHsu Sep 27, 2024
8f225c0
remove more anys to appease format gods
LouiseHsu Sep 27, 2024
2c6efdb
Merge branch 'main' into iap_add_purchase
LouiseHsu Sep 27, 2024
72ce51c
a lil bit of refactioring
LouiseHsu Oct 1, 2024
2e940fe
Merge branch 'iap_add_purchase' of github.com:LouiseHsu/packages into…
LouiseHsu Oct 1, 2024
442c158
better error messages
LouiseHsu Oct 1, 2024
f48510b
some refactoring
LouiseHsu Oct 1, 2024
6076bf1
.
LouiseHsu Oct 1, 2024
d8dcad2
remove uneeded filed
LouiseHsu Oct 2, 2024
9c2893b
oops pathing
LouiseHsu Oct 2, 2024
1a74fb7
.
LouiseHsu Oct 2, 2024
1b688ae
.
LouiseHsu Oct 2, 2024
74c2de3
.
LouiseHsu Oct 4, 2024
71c9a1b
.
LouiseHsu Oct 4, 2024
582156b
no message
LouiseHsu Oct 4, 2024
e6bec70
.
LouiseHsu Oct 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
.
  • Loading branch information
LouiseHsu committed Oct 2, 2024
commit 1b688ae80e81d7b94407abad6a75ceb27ca2dcfa
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public class InAppPurchasePlugin: NSObject, FlutterPlugin, InAppPurchaseAPI {

// This should be an Task, but Task is on available >= iOS 13
var updateListenerTask: Any?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try out that getter trick discussed yesterday?


var transactionCallbackAPI: InAppPurchase2CallbackAPI? = nil

public static func register(with registrar: FlutterPluginRegistrar) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

@available(iOS 15.0, macOS 12.0, *)
extension InAppPurchasePlugin: InAppPurchase2API {
var updateListenerTaskAsTask: Task<(), Never> {
return self.updateListenerTask as! Task<(), Never>
}

// MARK: - Pigeon Functions

/// Wrapper method around StoreKit2's canMakePayments() method
Expand Down Expand Up @@ -94,10 +98,10 @@ extension InAppPurchasePlugin: InAppPurchase2API {
Task {
@MainActor in
do {
let transactionsMessages = await rawTransactions().map {
let transactionsMsgs = await rawTransactions().map {
$0.convertToPigeon()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use keypath

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Keypath can’t be used on instance methods"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you are right

}
completion(.success(transactionsMessages))
completion(.success(transactionsMsgs))
}
}
}
Expand Down Expand Up @@ -130,7 +134,7 @@ extension InAppPurchasePlugin: InAppPurchase2API {

/// Stop subscribing to Transaction.updates
func stopListeningToTransactions() throws {
getUpdateListenerTask().cancel()
updateListenerTaskAsTask.cancel()
}

/// Sends an transaction back to Dart. Access these transactions with `purchaseStream`
Expand Down Expand Up @@ -173,9 +177,4 @@ extension InAppPurchasePlugin: InAppPurchase2API {
}
return nil
}

/// Helper function to cast updateListenerTask to a task
func getUpdateListenerTask() -> Task<(), Never> {
return self.updateListenerTask as! Task<(), Never>
}
}