Skip to content

[google_maps_flutter] Disable setAndGetScrollPosition on iOS #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Sep 9, 2024
Merged

[google_maps_flutter] Disable setAndGetScrollPosition on iOS #7609

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9f20a1
Disable in app-facing
stuartmorgan-g Sep 9, 2024
eb893ef
Disable in implementation package
stuartmorgan-g Sep 9, 2024
b81cfe1
Missed test
stuartmorgan-g Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable in implementation package
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g authored Sep 9, 2024
commit eb893ef0a339892e35f1d52bfc58ad1fc9e7f002
3 changes: 2 additions & 1 deletion ...utter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,8 @@ Future<void> main() async {
});
},
// Scroll position is currently not implemented for macOS.
skip: Platform.isMacOS);
// Flakes on iOS: https://github.com/flutter/flutter/issues/154826
skip: Platform.isMacOS || Platform.isIOS);

group('NavigationDelegate', () {
const String blankPage = '<!DOCTYPE html><head></head><body></body></html>';
Expand Down