Skip to content

[google_maps_flutter_platform_interface] Fix typo in CameraUpdateNewLatLngBounds.toJson #7626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaakovschectman merged 2 commits into from
Sep 11, 2024
Merged

[google_maps_flutter_platform_interface] Fix typo in CameraUpdateNewLatLngBounds.toJson #7626

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e06aee
Fix typo
yaakovschectman Sep 11, 2024
15796b5
Test JSON tags
yaakovschectman Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Test JSON tags
  • Loading branch information
@yaakovschectman
yaakovschectman committed Sep 11, 2024
commit 15796b54bfd2afbcac21586e196b1cb081180489
16 changes: 16 additions & 0 deletions ...es/google_maps_flutter/google_maps_flutter_platform_interface/test/types/camera_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ void main() {
expect(cameraUpdate.updateType, CameraUpdateType.newCameraPosition);
cameraUpdate as CameraUpdateNewCameraPosition;
expect(cameraUpdate.cameraPosition, cameraPosition);
final List<Object> jsonList = cameraUpdate.toJson() as List<Object>;
expect(jsonList[0], 'newCameraPosition');
});

test('CameraUpdate.newLatLng', () {
Expand All @@ -39,6 +41,8 @@ void main() {
expect(cameraUpdate.updateType, CameraUpdateType.newLatLng);
cameraUpdate as CameraUpdateNewLatLng;
expect(cameraUpdate.latLng, latLng);
final List<Object> jsonList = cameraUpdate.toJson() as List<Object>;
expect(jsonList[0], 'newLatLng');
});

test('CameraUpdate.newLatLngBounds', () {
Expand All @@ -52,6 +56,8 @@ void main() {
cameraUpdate as CameraUpdateNewLatLngBounds;
expect(cameraUpdate.bounds, latLngBounds);
expect(cameraUpdate.padding, padding);
final List<Object> jsonList = cameraUpdate.toJson() as List<Object>;
expect(jsonList[0], 'newLatLngBounds');
});

test('CameraUpdate.newLatLngZoom', () {
Expand All @@ -63,6 +69,8 @@ void main() {
cameraUpdate as CameraUpdateNewLatLngZoom;
expect(cameraUpdate.latLng, latLng);
expect(cameraUpdate.zoom, zoom);
final List<Object> jsonList = cameraUpdate.toJson() as List<Object>;
expect(jsonList[0], 'newLatLngZoom');
});

test('CameraUpdate.scrollBy', () {
Expand All @@ -74,6 +82,8 @@ void main() {
cameraUpdate as CameraUpdateScrollBy;
expect(cameraUpdate.dx, dx);
expect(cameraUpdate.dy, dy);
final List<Object> jsonList = cameraUpdate.toJson() as List<Object>;
expect(jsonList[0], 'scrollBy');
});

test('CameraUpdate.zoomBy', () {
Expand All @@ -85,17 +95,23 @@ void main() {
cameraUpdate as CameraUpdateZoomBy;
expect(cameraUpdate.amount, amount);
expect(cameraUpdate.focus, focus);
final List<Object> jsonList = cameraUpdate.toJson() as List<Object>;
expect(jsonList[0], 'zoomBy');
});

test('CameraUpdate.zoomIn', () {
final CameraUpdate cameraUpdate = CameraUpdate.zoomIn();
expect(cameraUpdate.runtimeType, CameraUpdateZoomIn);
expect(cameraUpdate.updateType, CameraUpdateType.zoomIn);
final List<Object> jsonList = cameraUpdate.toJson() as List<Object>;
expect(jsonList[0], 'zoomIn');
});

test('CameraUpdate.zoomOut', () {
final CameraUpdate cameraUpdate = CameraUpdate.zoomOut();
expect(cameraUpdate.runtimeType, CameraUpdateZoomOut);
expect(cameraUpdate.updateType, CameraUpdateType.zoomOut);
final List<Object> jsonList = cameraUpdate.toJson() as List<Object>;
expect(jsonList[0], 'zoomOut');
});
}