Skip to content

Add support for passing query parameters into benchmark URIs #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kenzieschmoll wants to merge 3 commits into from
Closed

Add support for passing query parameters into benchmark URIs #7632

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7951b7
Add support for passing query parameters into benchmark URIs
kenzieschmoll Sep 11, 2024
28ac226
.
kenzieschmoll Sep 11, 2024
96e23d8
formatting
kenzieschmoll Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
formatting
  • Loading branch information
@kenzieschmoll
kenzieschmoll committed Sep 11, 2024
commit 96e23d8738e34f31af2c2bbb837e4df74f49a10e
10 changes: 5 additions & 5 deletions packages/web_benchmarks/lib/server.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,18 @@ const int defaultChromeDebugPort = 10000;
///
/// If [headless] is true, runs Chrome without UI. In particular, this is
/// useful in environments (e.g. CI) that doesn't have a display.
///
///
/// If [treeShakeIcons] is false, '--no-tree-shake-icons' will be passed as a
/// build argument when building the benchmark app.
///
///
/// [initialPage] specifies the 'path' of the URL to load upon opening the
/// benchmark app in Chrome.
///
///
/// [queryParameters] specifies the 'queryParameters' of the URL to load upon
/// opening the benchmark app in Chrome.
///
///
/// [compilationOptions] specify the compiler and renderer to use for the
/// benchmark app. This can either use dart2wasm & skwasm or
/// benchmark app. This can either use dart2wasm & skwasm or
/// dart2js & canvaskit.
Future<BenchmarkResults> serveWebBenchmark({
required io.Directory benchmarkAppDirectory,
Expand Down