Skip to content

[google_maps_flutter_android] Add PlatformCap pigeon type. #7639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaakovschectman merged 16 commits into from
Oct 9, 2024
Merged

[google_maps_flutter_android] Add PlatformCap pigeon type. #7639

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7f09414
Define Cap pigeon
yaakovschectman Sep 12, 2024
35580cf
Update dart code
yaakovschectman Sep 12, 2024
65487c4
Update java code
yaakovschectman Sep 12, 2024
29c21c0
Formatting
yaakovschectman Sep 12, 2024
1201764
Bump version
yaakovschectman Sep 12, 2024
a718936
Comment conversion method
yaakovschectman Sep 12, 2024
9de05c8
TODO for Cap
yaakovschectman Sep 12, 2024
5960b31
TODO on BitmapDescriptor
yaakovschectman Sep 12, 2024
e78e7bc
Document maps SDK cap
yaakovschectman Sep 13, 2024
226161a
Merge branch 'main' into pigeon_cap
yaakovschectman Sep 23, 2024
87c5f1e
Regenerate pigeons
yaakovschectman Sep 23, 2024
daf0cd6
Remove outdated comment
yaakovschectman Oct 1, 2024
74fd373
PR Feedback
yaakovschectman Oct 2, 2024
05345fc
Format
yaakovschectman Oct 2, 2024
2179d48
Merge branch 'main' into pigeon_cap
yaakovschectman Oct 9, 2024
5b2531a
Version bump
yaakovschectman Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TODO for Cap
  • Loading branch information
@yaakovschectman
yaakovschectman committed Sep 23, 2024
commit 9de05c85b7c5296aa99b54911b120066504bb627
2 changes: 2 additions & 0 deletions .../google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,6 +1169,8 @@ PlatformJointType platformJointTypeFromJointType(JointType jointType) {
/// Converts platform interface's Cap to Pigeon's PlatformCap.
Copy link
Contributor

@reidbaker reidbaker Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No action required: You are following the pattern of the rest of this file but both this method name and documentation do not help me understand what is being converted here or how to learn about either the to or from object.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could trivially improve them all a fair amount by using [] references for both class names. That was just an oversight on my part when I started converting.

Copy link
Contributor

@reidbaker reidbaker Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use dart doc linking notation for the classes.

@visibleForTesting
PlatformCap platformCapFromCap(Cap cap) {
// TODO(schectman): Convert Cap to structured data.
// https://github.com/flutter/flutter/issues/155121
final List<Object> json = cap.toJson() as List<Object>;
final String tag = json[0] as String;
switch (tag) {
Expand Down