Skip to content

[interactive_media_ads] Adds internal wrapper for iOS native IMAFriendlyObstruction #7696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 12 commits into from
Sep 26, 2024
Merged

[interactive_media_ads] Adds internal wrapper for iOS native IMAFriendlyObstruction #7696

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4062db4
impl done but with some broken code
bparrishMines Sep 18, 2024
abc2fe4
gen should be fixed
bparrishMines Sep 25, 2024
dfff5fe
fix pigeon version
bparrishMines Sep 25, 2024
9bb930e
add registrar impl
bparrishMines Sep 25, 2024
d0ff8a6
version bump
bparrishMines Sep 25, 2024
fee0be4
request version bump
bparrishMines Sep 26, 2024
e2f12bf
Merge branch 'main' of github.com:flutter/packages into ima_ios_friendly
bparrishMines Sep 26, 2024
d85ba02
centralize error creation
bparrishMines Sep 26, 2024
bb631df
add test file to project
bparrishMines Sep 26, 2024
a6ef553
add test file to project
bparrishMines Sep 26, 2024
366fbf8
add error test
bparrishMines Sep 26, 2024
6254d41
add parent class to test
bparrishMines Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add error test
  • Loading branch information
@bparrishMines
bparrishMines committed Sep 26, 2024
commit 366fbf849bd40a50c160358bb44c616bbe2b6426
10 changes: 6 additions & 4 deletions packages/interactive_media_ads/example/ios/RunnerTests/FriendlyObstructionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,16 @@ class FriendlyObstructionProxyApiTest {
pigeonApi: api, view: UIView(), purpose: .mediaControls, detailedReason: "myString")
XCTAssertNotNil(instance)
}

func testPigeonDefaultConstructorWithUnknownPurpose() {
let registrar = TestProxyApiRegistrar()
let api = registrar.apiDelegate.pigeonApiIMAFriendlyObstruction(registrar)

XCTAssertThrowsError(try api.pigeonDelegate.pigeonDefaultConstructor(
pigeonApi: api, view: UIView(), purpose: .unknown, detailedReason: "myString")) { error in
XCTAssertTrue(error is PigeonError)
XCTAssertThrowsError(
try api.pigeonDelegate.pigeonDefaultConstructor(
pigeonApi: api, view: UIView(), purpose: .unknown, detailedReason: "myString")
) { error in
XCTAssertTrue(error is PigeonError)
}
}

Expand Down