Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
separated documentation hub error check for imperative method check
  • Loading branch information
jesswrd committed Oct 29, 2024
commit 5629ea36d67279161c7794854b53dd3320a9fd12
1 change: 0 additions & 1 deletion script/tool/lib/src/gradle_check_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ class GradleCheckCommand extends PackageLoopingCommand {
/// configuration that enables artifact hub env variable.
@visibleForTesting
static String exampleRootSettingsArtifactHubString = '''
// See $artifactHubDocumentationString for more info.
buildscript {
repositories {
maven {
Expand Down
14 changes: 10 additions & 4 deletions script/tool/test/gradle_check_command_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ ${warningsConfigured ? warningConfig : ''}
void writeFakeExampleTopLevelSettingsGradle(
RepositoryPackage package, {
bool includeArtifactHub = true,
bool includeArtifactDocumentation = true,
}) {
final File settingsGradle = package
.platformDirectory(FlutterPlatform.android)
Expand All @@ -196,6 +197,7 @@ plugins.each { name, path ->
include ":\$name"
project(":\$name").projectDir = pluginDirectory
}
${includeArtifactDocumentation ? '// See ${GradleCheckCommand.artifactHubDocumentationString} for more info.' : ''}
${includeArtifactHub ? GradleCheckCommand.exampleRootSettingsArtifactHubString : ''}
''');
}
Expand Down Expand Up @@ -305,6 +307,7 @@ dependencies {
String? kotlinVersion,
bool includeBuildArtifactHub = true,
bool includeSettingsArtifactHub = true,
bool includeSettingsDocumentationArtifactHub = true,
}) {
writeFakeExampleTopLevelBuildGradle(
package,
Expand All @@ -318,6 +321,7 @@ dependencies {
writeFakeExampleTopLevelSettingsGradle(
package,
includeArtifactHub: includeSettingsArtifactHub,
includeArtifactDocumentation: includeSettingsDocumentationArtifactHub,
);
}

Expand All @@ -330,7 +334,7 @@ dependencies {
String? kotlinVersion,
bool includeBuildArtifactHub = true,
bool includeSettingsArtifactHub = true,
bool includeDocumentationArtifactHub = true,
bool includeSettingsDocumentationArtifactHub = true,
}) {
writeFakeExampleTopLevelBuildGradle(
package,
Expand All @@ -344,7 +348,7 @@ dependencies {
writeFakeExampleSettingsGradle(
package,
includeArtifactHub: includeSettingsArtifactHub,
includeArtifactDocumentation: includeDocumentationArtifactHub,
includeArtifactDocumentation: includeSettingsDocumentationArtifactHub,
);
}

Expand Down Expand Up @@ -751,6 +755,8 @@ dependencies {
includeBuildArtifactHub: true,
// ignore: avoid_redundant_argument_values
includeSettingsArtifactHub: true,
// ignore: avoid_redundant_argument_values
includeSettingsDocumentationArtifactHub: true
);
writeFakeManifest(example, isApp: true);

Expand Down Expand Up @@ -877,7 +883,7 @@ dependencies {
includeBuildArtifactHub: true,
includeSettingsArtifactHub: false,
// ignore: avoid_redundant_argument_values
includeDocumentationArtifactHub: true);
includeSettingsDocumentationArtifactHub: true);
writeFakeManifest(example, isApp: true);

Error? commandError;
Expand Down Expand Up @@ -912,7 +918,7 @@ dependencies {
includeBuildArtifactHub: true,
// ignore: avoid_redundant_argument_values
includeSettingsArtifactHub: true,
includeDocumentationArtifactHub: false);
includeSettingsDocumentationArtifactHub: false);
writeFakeManifest(example, isApp: true);

Error? commandError;
Expand Down