Skip to content

[camerax] Revert "Explicitly remove READ_EXTERNAL_STORAGE permission" #7826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Oct 9, 2024
Merged

[camerax] Revert "Explicitly remove READ_EXTERNAL_STORAGE permission" #7826

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
241baaa
add base change
camsim99 Oct 8, 2024
a9d8295
edits
camsim99 Oct 8, 2024
b7ee72f
nit
camsim99 Oct 8, 2024
d2813b5
Rewrite
camsim99 Oct 9, 2024
3b4cbf0
add back res link
camsim99 Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add back res link
  • Loading branch information
@camsim99
camsim99 committed Oct 9, 2024
commit 3b4cbf09b6c1f799f3bba7f0d07bfb207b394141
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ requires specifying the `WRITE_EXTERNAL_STORAGE` permission (see [the CameraX do
This is already done in the plugin, so no further action is required on your end.

To understand the privacy impact of specifying the `WRITE_EXTERNAL_STORAGE` permission, see the
[`WRITE_EXTERNAL_STORAGE` documentation][11]. We have seen apps also have the `READ_EXTERNAL_STORAGE`
[`WRITE_EXTERNAL_STORAGE` documentation][11]. We have seen apps also have the [`READ_EXTERNAL_STORAGE`][13]
permission automatically added to the merged Android manifest; it appears to be implied from
`WRITE_EXTERNAL_STORAGE`. If you do not want the `READ_EXTERNAL_STORAGE` permission to be included
in the merged Android manifest of your app, then take the following steps to remove it:
Expand Down