Skip to content

[video_player_android] Correct rotation of videos recorded by the camera #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 16 commits into from
Oct 21, 2024
Merged

[video_player_android] Correct rotation of videos recorded by the camera #7846

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5b8ad64
debugging
camsim99 Oct 9, 2024
bbac0c3
theoretical fix
camsim99 Oct 10, 2024
43898cb
Mild cleanup
camsim99 Oct 10, 2024
95d5e43
Undo extra import
camsim99 Oct 10, 2024
3306352
Fix logic + start tests
camsim99 Oct 15, 2024
3524885
Merge remote-tracking branch 'upstream/main' into vp_fix
camsim99 Oct 16, 2024
2664b51
Fix code + add tests
camsim99 Oct 16, 2024
1ba7efc
Remove print statement, bump version
camsim99 Oct 16, 2024
0ff09c6
Add Impeller case
camsim99 Oct 16, 2024
a374698
Merge remote-tracking branch 'upstream/main' into vp_fix
camsim99 Oct 17, 2024
a74cea9
Cleanup
camsim99 Oct 17, 2024
da92163
Add comment
camsim99 Oct 17, 2024
1a65eea
Correct changelog
camsim99 Oct 17, 2024
ee0f7de
Address review
camsim99 Oct 18, 2024
fc22ee6
Merge remote-tracking branch 'upstream/main' into vp_fix
camsim99 Oct 18, 2024
5f2a824
address review
camsim99 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment
  • Loading branch information
@camsim99
camsim99 committed Oct 17, 2024
commit da92163017fca1e5ff8f317d7b4d77d3c506d4c5
2 changes: 2 additions & 0 deletions ..._android/android/src/main/java/io/flutter/plugins/videoplayer/ExoPlayerEventListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ private int getRotationCorrectionFromUnappliedRotation(int unappliedRotationDegr
}

@OptIn(markerClass = androidx.media3.common.util.UnstableApi.class)
// The annotation is used to enable using a Format to determine the rotation
Copy link
Contributor

@reidbaker reidbaker Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment should instead of explaining what an unstable api annotation does should instead explain why it is ok to use an unstable api and what the failure modes are that we can expect. (for example should we expect the signature to possibly change across minor versions).

// correction.
private int getRotationCorrectionFromFormat(ExoPlayer exoPlayer) {
Format videoFormat = Objects.requireNonNull(exoPlayer.getVideoFormat());
return videoFormat.rotationDegrees;
Expand Down