Skip to content

[pigeon] Allows swift generator to skip error class generation #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 11 commits into from
Oct 23, 2024
Merged

[pigeon] Allows swift generator to skip error class generation #7849

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cb7aaef
allows swift generator to skip error class generation
wamynobe Oct 11, 2024
5faea22
update CHANGELOG.md
wamynobe Oct 11, 2024
79a54b0
Remove redundant code
wamynobe Oct 12, 2024
b50fd13
Update CHANGELOG.md
wamynobe Oct 12, 2024
3445c08
Merge branch 'main' into swift-error-sharing
wamynobe Oct 15, 2024
e354fd6
update CHANGELOG.md
wamynobe Oct 17, 2024
028e0ba
Merge branch 'main' into swift-error-sharing
wamynobe Oct 17, 2024
865a7d0
Update test cases generation for swift
wamynobe Oct 18, 2024
0723978
Merge branch 'main' into swift-error-sharing
wamynobe Oct 18, 2024
9c42c52
Update test cases generation for swift
wamynobe Oct 18, 2024
2af93d3
Merge branch 'main' into swift-error-sharing
wamynobe Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test cases generation for swift
  • Loading branch information
@wamynobe
wamynobe committed Oct 18, 2024
commit 9c42c52e8b176f3bcac6738a23a1763df1169990
1 change: 1 addition & 0 deletions packages/pigeon/tool/shared/generation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ Future<int> generateTestPigeons(
? null
: '$outputBase/macos/Classes/$pascalCaseName.gen.swift',
swiftErrorClassName: swiftErrorClassName,
swiftIncludeErrorClass: input != 'core_tests',
suppressVersion: true,
dartPackageName: 'pigeon_integration_tests',
injectOverflowTypes: includeOverflow && input == 'core_tests',
Expand Down