Skip to content

[video_player_android] Give can pause integration test range to test for #7913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camsim99 merged 10 commits into from
Oct 23, 2024
Merged

[video_player_android] Give can pause integration test range to test for #7913

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
95b9477
Add diff
camsim99 Oct 22, 2024
e27fe44
Bump diff
camsim99 Oct 22, 2024
13bb6cf
Fix units
camsim99 Oct 23, 2024
1898dba
Change diff from s to ms
camsim99 Oct 23, 2024
b89f0f9
Increase diff
camsim99 Oct 23, 2024
27eaff2
Increase diff
camsim99 Oct 23, 2024
da0efeb
Bump version
camsim99 Oct 23, 2024
280fef6
Add back missing pump and settle
camsim99 Oct 23, 2024
b5215c7
undo changelog and versioning
camsim99 Oct 23, 2024
9de058a
undo todo
camsim99 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add back missing pump and settle
  • Loading branch information
@camsim99
camsim99 committed Oct 23, 2024
commit 280fef63a80042d6596e5f25a0d549e07ff88c80
3 changes: 2 additions & 1 deletion packages/video_player/video_player_android/example/integration_test/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,13 @@ void main() {
await tester.pumpAndSettle(_playDuration);

await player.pause(textureId);
await tester.pumpAndSettle(_playDuration);
final Duration pausedDuration = await player.getPosition(textureId);
await tester.pumpAndSettle(_playDuration);

// TODO(camsim99): Implement reliable way to tell when pausing completes
// to check for exact pausedDuration.
expect((await player.getPosition(textureId)).inMilliseconds, inInclusiveRange(pausedDuration.inMilliseconds, pausedDuration.inMilliseconds + 500));
expect(await player.getPosition(textureId), pausedDuration);
await player.dispose(textureId);
});

Expand Down