Skip to content

[image_picker_macos] macOS native image picker #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EchoEllet wants to merge 18 commits into from
Closed

[image_picker_macos] macOS native image picker #8079

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1d8ec6c
chore(example): update outdated macOS example using Flutter build mac…
EchoEllet Oct 2, 2024
6ba3c14
feat(image_picker_macos): add support for native macOS image picker
EchoEllet Nov 13, 2024
c98699f
chore: generate pigeons and mocks with the latest dev dependencies
EchoEllet Nov 14, 2024
f420c91
chore: format Swift generated file Messages.g.swift
EchoEllet Nov 14, 2024
3f49936
chore: restore backticks of file_selector link
EchoEllet Nov 14, 2024
31c4f55
chore: update supported macOS version from 10.11 to 10.14 for image_p…
EchoEllet Nov 14, 2024
abd926c
chore: use getVideo() instead of the soft-deprecated pickVideo() in u…
EchoEllet Nov 14, 2024
75badd9
chore: update outdated TODOs as they moved to https://github.com/flut…
EchoEllet Nov 14, 2024
200cb10
test: add minor test for pickVideo
EchoEllet Nov 14, 2024
d1bee0a
chore: run dart format for Dart generated files
EchoEllet Nov 14, 2024
30fd055
chore: 'try' precede 'await' in ImagePickerImpl.swift
EchoEllet Nov 14, 2024
5edff64
chore: hardcode the supportsPHPicker() name to fix CI warnings
EchoEllet Nov 14, 2024
0aaf366
chore: remove @visibleForTesting from supportsPHPicker
EchoEllet Jan 2, 2025
527ac48
chore: remove unnecessary assertions from NSImage.compressed
EchoEllet Jan 2, 2025
b10b41f
refactor: require quality as not nil in shouldCompressImage to avoid …
EchoEllet Jan 2, 2025
0caa390
chore: remove unnecessary assertion from imageFileExt
EchoEllet Jan 2, 2025
b6582fe
chore: extract duplicated createTestImage from ImageCompressTests and…
EchoEllet Jan 2, 2025
c531757
feat: improve error handling, avoid hardcoding string error codes, us…
EchoEllet Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove @VisibleForTesting from supportsPHPicker
  • Loading branch information
@EchoEllet
EchoEllet committed Jan 4, 2025
commit 0aaf366aad8deaf281955760aa110dc08cdcce50
1 change: 0 additions & 1 deletion packages/image_picker/image_picker_macos/lib/image_picker_macos.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ class ImagePickerMacOS extends CameraDelegatingImagePickerPlatform {
///
/// The [PHPicker](https://developer.apple.com/documentation/photokit/phpickerviewcontroller)
/// is **supported on macOS 13.0+**
@visibleForTesting
Future<bool> supportsPHPicker() => _hostApi.supportsPHPicker();

/// Returns `true` if [ImagePickerMacOS] should use [PHPicker](https://developer.apple.com/documentation/photokit/phpickerviewcontroller).
Expand Down