Skip to content

[pigeon] Enable example app build in CI #8119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Nov 20, 2024
Merged

[pigeon] Enable example app build in CI #8119

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db49502
[pigeon] Enable example app build in CI
stuartmorgan-g Nov 18, 2024
b03965c
excerpts
stuartmorgan-g Nov 18, 2024
f965c8b
macos
stuartmorgan-g Nov 18, 2024
8cf4ca9
windows
stuartmorgan-g Nov 20, 2024
5c74f0f
windows-excerpt
stuartmorgan-g Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions ...on/example/app/android/app/src/main/kotlin/dev/flutter/pigeon_example_app/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import ExampleHostApi
import FlutterError
import MessageData
import MessageFlutterApi
import androidx.annotation.NonNull
import io.flutter.embedding.android.FlutterActivity
import io.flutter.embedding.engine.FlutterEngine
import io.flutter.embedding.engine.plugins.FlutterPlugin
Expand Down Expand Up @@ -37,22 +36,21 @@ private class PigeonApiImplementation : ExampleHostApi {
// #enddocregion kotlin-class

// #docregion kotlin-class-flutter
private class PigeonFlutterApi {

private class PigeonFlutterApi(binding: FlutterPlugin.FlutterPluginBinding) {
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the constructor->init change were an Android Studio-suggested refactor; I figured I might as well update it to follow recommendations while I was there, but I can back this part out if we don't want it.

var flutterApi: MessageFlutterApi? = null

constructor(binding: FlutterPlugin.FlutterPluginBinding) {
flutterApi = MessageFlutterApi(binding.getBinaryMessenger())
init {
flutterApi = MessageFlutterApi(binding.binaryMessenger)
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a Kotlin style suggestion from AS.

}

fun callFlutterMethod(aString: String, callback: (Result<String>) -> Unit) {
flutterApi!!.flutterMethod(aString) { echo -> callback(Result.success(echo)) }
flutterApi!!.flutterMethod(aString) { echo -> callback(echo) }
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion in another PR, this code is wrong, and we just hadn't noticed because it wasn't building.

}
}
// #enddocregion kotlin-class-flutter

class MainActivity : FlutterActivity() {
override fun configureFlutterEngine(@NonNull flutterEngine: FlutterEngine) {
override fun configureFlutterEngine(flutterEngine: FlutterEngine) {
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AS flagged that we shouldn't be using nullability annotations in Kotlin.

super.configureFlutterEngine(flutterEngine)

val api = PigeonApiImplementation()
Expand Down
6 changes: 3 additions & 3 deletions packages/pigeon/example/app/ios/Runner/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,16 @@ private class PigeonFlutterApi {
}

func callFlutterMethod(
aString aStringArg: String?, completion: @escaping (Result<String, Error>) -> Void
aString aStringArg: String?, completion: @escaping (Result<String, PigeonError>) -> Void
) {
flutterAPI.flutterMethod(aString: aStringArg) {
completion(.success($0))
completion($0)
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the Kotlin file, this was wrong and didn't compile.

}
}
}
// #enddocregion swift-class-flutter

@UIApplicationMain
@main
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a Flutter tool auto-migration; I didn't see any reason to undo it.

@objc class AppDelegate: FlutterAppDelegate {
override func application(
_ application: UIApplication,
Expand Down
11 changes: 0 additions & 11 deletions packages/pigeon/example/pubspec.yaml
View file
Open in desktop

This file was deleted.