-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[google_maps_flutter] Use structured Pigeon data on iOS #8142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 16 commits into
flutter:main
from
stuartmorgan-g:maps-ios-pigeon-completion
Nov 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f3b73b0
WIP for cameraUpdate, updating native tests
stuartmorgan-g 1fe07c9
Update Pigeon definition to (mostly) match Android
stuartmorgan-g ac98522
Update Dart code
stuartmorgan-g 5e88615
Update Dart unit tests from Android version
stuartmorgan-g 58aae26
Remove all the test dependencies on Pigeon encoding format
stuartmorgan-g 9c6981d
Port test improvements back to Android
stuartmorgan-g 2b04e31
WP - Update native code
stuartmorgan-g 73d9e15
Native code updates
stuartmorgan-g f212967
Revert unrelated project changes
stuartmorgan-g 87711b6
Version bump
stuartmorgan-g 27a3625
Revert iOS 15 project too
stuartmorgan-g 8cdd24f
Remove cap, which iOS doesn't use
stuartmorgan-g 416bab0
Remove Android SDK references
stuartmorgan-g 83721b7
Doc lint fix
stuartmorgan-g 7fc67d1
Warning fixes, cap test cleanup
stuartmorgan-g 96ccac0
Review comments
stuartmorgan-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update Dart code
- Loading branch information
commit ac985222ab6ee47ae78a5921f572ffc96d871fe4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and (a couple times, but not all times) below: ultra pedantic nit:
https://dart.dev/effective-dart/documentation#prefer-starting-function-or-method-comments-with-third-person-verbs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a nit I usually leave, so I'm happy to fix it :) I didn't notice when I pasted these in from Android.