Skip to content

[path_provider] Clean up Java code #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Dec 9, 2024
Merged

[path_provider] Clean up Java code #8240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72139b3
Remove unused files
stuartmorgan-g Dec 6, 2024
8c6471d
Inline implementations
stuartmorgan-g Dec 6, 2024
13855dd
Version bump
stuartmorgan-g Dec 6, 2024
f97ae2c
Convert tests
stuartmorgan-g Dec 9, 2024
0889c10
Autoformat
stuartmorgan-g Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Convert tests
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Dec 9, 2024
commit f97ae2c41f36af2ba9991092aaa24de603720849
5 changes: 4 additions & 1 deletion ...der_android/android/src/main/java/io/flutter/plugins/pathprovider/PathProviderPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
import android.util.Log;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.annotation.VisibleForTesting;

import io.flutter.embedding.engine.plugins.FlutterPlugin;
import io.flutter.plugin.common.BinaryMessenger;
import io.flutter.plugins.pathprovider.Messages.PathProviderApi;
Expand Down Expand Up @@ -94,7 +96,8 @@ public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) {
return paths;
}

private String getStorageDirectoryString(@NonNull Messages.StorageDirectory directory) {
@VisibleForTesting
String getStorageDirectoryString(@NonNull Messages.StorageDirectory directory) {
switch (directory) {
case ROOT:
return null;
Expand Down
25 changes: 25 additions & 0 deletions ...android/android/src/test/java/io/flutter/plugins/pathprovider/PathProviderPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

package io.flutter.plugins.pathprovider;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;

public class PathProviderPluginTest {
@org.junit.Test
public void testStorageDirectoryTypeTranslation() {
final PathProviderPlugin plugin = new PathProviderPlugin();
assertNull(plugin.getStorageDirectoryString(Messages.StorageDirectory.ROOT));
assertEquals("music", plugin.getStorageDirectoryString(Messages.StorageDirectory.MUSIC));
assertEquals("podcasts", plugin.getStorageDirectoryString(Messages.StorageDirectory.PODCASTS));
assertEquals("ringtones", plugin.getStorageDirectoryString(Messages.StorageDirectory.RINGTONES));
assertEquals("alarms", plugin.getStorageDirectoryString(Messages.StorageDirectory.ALARMS));
assertEquals("notifications", plugin.getStorageDirectoryString(Messages.StorageDirectory.NOTIFICATIONS));
assertEquals("pictures", plugin.getStorageDirectoryString(Messages.StorageDirectory.PICTURES));
assertEquals("movies", plugin.getStorageDirectoryString(Messages.StorageDirectory.MOVIES));
assertEquals("downloads", plugin.getStorageDirectoryString(Messages.StorageDirectory.DOWNLOADS));
assertEquals("dcim", plugin.getStorageDirectoryString(Messages.StorageDirectory.DCIM));
}
}
Loading