-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[webview_flutter_wkwebview] Updates the internal wrapper to use @ProxyApi from pigeon
#8311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 252 commits into
flutter:main
from
bparrishMines:webview_darwin_proxy
Jan 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
252 commits
Select commit
Hold shift + click to select a range
f75f6b1
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 859c3d3
configure fixed it
bparrishMines 5496891
formatted code
bparrishMines 999bf22
save these files i think
bparrishMines b5930f8
remove modulemap
bparrishMines 913b245
compiling code
bparrishMines 9dbf0a5
create a wrapper for urlrequest
bparrishMines 5050376
maybe finish controller
bparrishMines 5135ffe
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 24f601f
start work on fixing tests
bparrishMines 2d7b482
fix some tests
bparrishMines e1281ba
fix navigation delegate tests
bparrishMines 13dbc4d
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines bee1811
w;oiefj
bparrishMines ff64f90
mock
bparrishMines 419a2eb
half of the tests
bparrishMines 1740a29
some more test fixes
bparrishMines 389788e
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 40ae802
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 13fc34c
more test fixes
bparrishMines b15cdde
finish controller tests
bparrishMines 7dcc650
cookie manager tests
bparrishMines 0d22adf
widget tests
bparrishMines a35c48e
fix legacy implementation
bparrishMines f0fc827
legacy cookie tests
bparrishMines e6fe379
first test in webview widget passed
bparrishMines 6494a65
initial url test
bparrishMines 07f3410
more fixed tests
bparrishMines 3ad8d9f
websettings tests
bparrishMines 85fa2b2
more test fixes
bparrishMines 98aee69
fix all unit tests
bparrishMines f0b0a94
some swift
bparrishMines cbc0856
fix errors
bparrishMines b863f4d
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines fa4c951
fix nullability
bparrishMines 49a1a05
navigation response impl
bparrishMines 5e5781f
error and frame info
bparrishMines 97d6e96
more impl
bparrishMines bf679bf
cookie impl
bparrishMines ebe0ba9
cookies authchallenge and websitedatastore impl
bparrishMines 7eb6fdf
uiview impl
bparrishMines f93a7cc
wkwebbviewconfiguration impl
bparrishMines b485d72
user content controller impl
bparrishMines 7d39659
WKPreferences impl
bparrishMines f6a041b
script message handler
bparrishMines a566208
new file
bparrishMines ec576a4
navigation delegate
bparrishMines 068942a
nsobject impl
bparrishMines 612ceb8
webview ui extensions
bparrishMines edcd528
webview impl
bparrishMines f204985
wkuidelegate impl
bparrishMines c63fa97
cookie store impl
bparrishMines fcd8b6a
scrollviewdelegate impl
bparrishMines 54043b4
credential impl
bparrishMines 869da71
protection space
bparrishMines c922725
url auth challenge impl
bparrishMines 41b9e19
url impl
bparrishMines 81fd166
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines daf7e50
fix int
bparrishMines 54bfff1
change plugin file
bparrishMines f14a81e
fix platform registry name
bparrishMines b41c21e
may fix for webview
bparrishMines 349c0f7
actually use URL
bparrishMines d512f44
use platform webview as solution
bparrishMines d494275
fix macos webview
bparrishMines bfa91ce
maybe fix http response
bparrishMines bff9db6
handle null just in case
bparrishMines 0cdf137
fix loadfileurl
bparrishMines 3d76c72
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines c236616
fix test classes
bparrishMines 5190205
fix integration tests
bparrishMines 00d1ecd
formatting
bparrishMines dd70fa2
fix gc test
bparrishMines a080026
remove ocmock and write first test
bparrishMines 668cdeb
error tests
bparrishMines 8816103
fix test class name
bparrishMines 1b23304
add innate webview settings
bparrishMines ffb8b9c
frame info tests
bparrishMines c0e5ab3
fix all current tests
bparrishMines a302eb2
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 38c43a2
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines d4acfda
cookie store tests
bparrishMines 88dc3bc
navigation action tests
bparrishMines 882504d
navigation delegate tests pass
bparrishMines 943d55c
uncomment tests i guess
bparrishMines ae8dc8c
navigation response tests
bparrishMines 9981881
comment out frame info
bparrishMines 0db825e
update code generation
bparrishMines 66b37e9
nsobject tests
bparrishMines 6ebba32
preferences test
bparrishMines edabb71
script message handler tests
bparrishMines e488ab4
script message tests
bparrishMines e01b4b0
scrollview delegate tests
bparrishMines 8ce00bb
scroll view tests
bparrishMines 88df578
securityorigin tests
bparrishMines 64a9c4d
help have tests pass
bparrishMines ff705af
ui delegate tests
bparrishMines 2474f2f
uiview tests
bparrishMines babc179
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 56083c5
fix frame
bparrishMines 973e2be
URLAuthenticationChallenge tests
bparrishMines 1d43b03
URLCredential tests
bparrishMines d03f8fc
protection space tests
bparrishMines 53d8aef
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 50c3e76
url request wrapper tests
bparrishMines e251caa
usercontent controller tess
bparrishMines a3eed42
user scripts tests
bparrishMines c016464
fix legacy names and website data store tests are broken
bparrishMines 3004001
fix tests
bparrishMines 52cae3a
webview configuration tests
bparrishMines 3c14d7f
fix inspectable
bparrishMines ec28dae
some tests for wkwebview
bparrishMines 30b49a3
fix flutter asset test
bparrishMines f91b734
can go back tests
bparrishMines f883a5b
finish webview tests
bparrishMines 538e24b
no printing
bparrishMines 47afa83
fix cookie store call
bparrishMines 701ab08
improve cookie test
bparrishMines 3a59e7e
add default handling for uidelegate and navigation delegate and forma…
bparrishMines d8b7c83
configuration for macos
bparrishMines 793ef57
ensure external api still works
bparrishMines 787df3e
remove flutter imports
bparrishMines 9b8548b
fix cookie tests
bparrishMines f5ec093
change expect name
bparrishMines ad3d45c
update auth challenge response
bparrishMines 9242d92
add null constructor error
bparrishMines bd54c6d
navigation delegate and above
bparrishMines 4c39451
update up to nsobject
bparrishMines 3291608
uiscrollviews
bparrishMines ab9210e
struct wrappers
bparrishMines 20e9791
wkuidelegate and fix other callback stuff
bparrishMines a4b2c85
up to URL
bparrishMines ddadc15
url request
bparrishMines fb0bc68
rest of classes
bparrishMines 4fb75b6
update docs for proxyapidelegate
bparrishMines 109fb15
improve error message
bparrishMines 814b33f
start of test fixes
bparrishMines 79e57a8
move to proxy api registrar holding the helper methods
bparrishMines e42c018
create a test registrar
bparrishMines 1f24e57
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines ec50474
cleanup tests
bparrishMines c8417c6
tests run
bparrishMines 25d90fd
fixed tests
bparrishMines de9f446
working on macos
bparrishMines 3e6f3cf
remove unsused file and change pigeon file name
bparrishMines ab4dac6
non helper generation
bparrishMines fb0649c
formatting
bparrishMines 8f98ec1
formatting and lint
bparrishMines 80588ac
add contribution
bparrishMines 6b9f199
start docs for platform webview
bparrishMines 1e16ac4
use long
bparrishMines 44c8bc0
forward method impl
bparrishMines f1c874b
scrollview tests
bparrishMines 48b3d4d
finish docs
bparrishMines 05f4fcd
fix analyze warnings
bparrishMines d2c657b
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 7fb5ac4
compilation on mac
bparrishMines 3a477c3
formatting
bparrishMines 449930a
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 2a9896f
version bump
bparrishMines 11a3d90
fix change
bparrishMines 0096db3
use value and not argb32
bparrishMines 48957f7
remove cocoapods
bparrishMines d707b60
try removing pods again
bparrishMines afa75fd
reremove old stuff
bparrishMines 5098045
work with swift package manager
bparrishMines e5bab49
maybe
bparrishMines 8a0c9e2
add main actor
bparrishMines 7806985
set swift version to 5
bparrishMines 0a81947
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 082e628
use swift 5 in tests
bparrishMines 7b06141
fix lint errors
bparrishMines beed9f5
fix macos maybe lol
bparrishMines a0c595f
fix native tests hopefully
bparrishMines 0763edb
docs for external api
bparrishMines 86bc1a2
remove use of any
bparrishMines ef63401
try fix last syntax error
bparrishMines 183d263
remove old test references on mac
bparrishMines 8b1b448
try fix lint
bparrishMines adcc442
try fix again
bparrishMines 19af387
try fix objc tag
bparrishMines 7f01bd1
lint fixes
bparrishMines dc138c4
remove the any usages
bparrishMines 9dcf6f2
hopefully last any
bparrishMines 9e3b41e
make public i guess lol
bparrishMines eff8031
make class public
bparrishMines 98bab3e
sofeja
bparrishMines 2cb82a2
move method to extension
bparrishMines 230bdac
move methods to extension
bparrishMines a2f9cd5
remove
bparrishMines 7aa551b
try changing using import
bparrishMines f6df68b
poqwiejfpwoiej doewijaeo;isj;s
bparrishMines 0fccbdc
move
bparrishMines fc57cbf
uaoijepfaeoija
bparrishMines 9eeabc7
ui delegate
bparrishMines 6a8c6ae
remove mainactor
bparrishMines 644c204
try to main thread
bparrishMines 56d57b4
fix uidlegate
bparrishMines 4c38801
user dispatch on main thread again
bparrishMines d20fbcf
expectations from
bparrishMines 129aeda
fix swift unit tests
bparrishMines d9bd5b2
try add h and removing use frameworks
bparrishMines 6ac9d27
add to runner
bparrishMines 57065b7
woe;ifj
bparrishMines 900786b
owiejf;a
bparrishMines 0cad230
delete
bparrishMines 700af73
add reference files
bparrishMines 7dfb124
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 04384e3
newline
bparrishMines d3811a6
move files
bparrishMines b609bc4
maybe fix tests again
bparrishMines 95b6cc5
any again
bparrishMines 122524c
faoiwej
bparrishMines 9f4de6b
alternative to main actor
bparrishMines 926f4d0
use ifdefs for xcode 5.0
bparrishMines 8ae290e
fix legacy
bparrishMines 46bc96b
values yo
bparrishMines d335c3a
fix mocks
bparrishMines 0481342
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 7600657
try move tests
bparrishMines 4472130
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 7e4d554
manual update
bparrishMines a3e7538
tests pass now idk
bparrishMines 854e470
fix external api name
bparrishMines a53db25
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 976750a
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 59254d7
fix onCanGoBackChange
bparrishMines c0d3558
add scrollview methods
bparrishMines d0847df
add other directional bounces
bparrishMines 0798846
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 27a409e
support xcode 15 i think
bparrishMines 6bf703e
a few fixes
bparrishMines ac194b1
remove unnneeded build
bparrishMines 00cd3c7
macos tests build
bparrishMines ce1892e
fix macos test
bparrishMines 0c80869
fix project.pbxproj
bparrishMines d501f3c
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines 4f7b90f
fix ios tests
bparrishMines f3a3bb4
maybe fix swift
bparrishMines ee93c01
fix let in testframeinfo
bparrishMines b454723
unused code
bparrishMines 5da3e6b
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines cf5eefd
try setting to nil
bparrishMines e438cf4
added a g
bparrishMines a612bbf
remove any
bparrishMines 5ba20a7
use default and try better test values
bparrishMines b796f10
remove excluded archs and .h from source files
bparrishMines e889fbe
fix objc name
bparrishMines 30a8ed9
fix swift name
bparrishMines 49e5a69
Merge branch 'main' of github.com:flutter/packages into webview_darwi…
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix external api name
- Loading branch information
commit 854e470ed80a4544fef77cb059fb75ad5a59fe38
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class was converted to Swift, but the
@objcannotations should provide the equivalent method (I wrote the swift test before creating the class).