Skip to content

[ci] Cumulative fixes to reopen the tree. #8344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Dec 23, 2024
Merged

[ci] Cumulative fixes to reopen the tree. #8344

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3792a8
[tool] Remove null-awareness from newly non-null field.
ditman Dec 23, 2024
f535b95
Skip network-dependent tests in Android.
ditman Dec 23, 2024
ecaad86
Merge branch 'main' into fix-tool-lints
ditman Dec 23, 2024
84fb55b
Bump version of pubspec_parse to ensure we always use the new API.
ditman Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip network-dependent tests in Android.
  • Loading branch information
@ditman
ditman committed Dec 23, 2024
commit f535b9559e978040a68dc370c82354c8fd34089a
18 changes: 18 additions & 0 deletions packages/video_player/video_player/example/integration_test/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ void main() {
testWidgets(
'live stream duration != 0',
(WidgetTester tester) async {
// This test requires network access, and won't pass until a LUCI recipe
// change is made.
// TODO(camsim99): Remove once https://github.com/flutter/flutter/issues/160797 is fixed.
if (!kIsWeb && Platform.isAndroid) {
markTestSkipped(
'Skipping due to https://github.com/flutter/flutter/issues/160797');
return;
}

final VideoPlayerController networkController =
VideoPlayerController.networkUrl(
Uri.parse(
Expand Down Expand Up @@ -266,6 +275,15 @@ void main() {
testWidgets(
'reports buffering status',
(WidgetTester tester) async {
// This test requires network access, and won't pass until a LUCI recipe
// change is made.
// TODO(camsim99): Remove once https://github.com/flutter/flutter/issues/160797 is fixed.
if (!kIsWeb && Platform.isAndroid) {
markTestSkipped(
'Skipping due to https://github.com/flutter/flutter/issues/160797');
return;
}

await controller.initialize();
// Mute to allow playing without DOM interaction on Web.
// See https://developers.google.com/web/updates/2017/09/autoplay-policy-changes
Expand Down
Loading