Skip to content

[tool] Build all_packages command against Flutter Android SDK version to match example app compileSdk constraints #8345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmagman wants to merge 2 commits into from
Closed

[tool] Build all_packages command against Flutter Android SDK version to match example app compileSdk constraints #8345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
584fc70
[tool] Build all_packages command against Flutter Android SDK version…
jmagman Dec 24, 2024
cd50629
Hardcode 35
jmagman Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Hardcode 35
  • Loading branch information
@jmagman
jmagman committed Feb 19, 2025
commit cd50629c69ff4a7874b53b25dc5e7a7cac13835e
9 changes: 4 additions & 5 deletions script/tool/lib/src/create_all_packages_app_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,8 @@ dependencies {}
_adjustFile(
gradleFile,
replacements: <String, List<String>>{
if (gradleFileIsKotlin)
'compileSdk': <String>['compileSdk = flutter.compileSdkVersion']
else ...<String, List<String>>{
'compileSdkVersion': <String>['compileSdk flutter.compileSdkVersion'],
}
'compileSdk': <String>['compileSdk = 35'],
'compileSdkVersion': <String>['compileSdk = 35'],
},
regexReplacements: <RegExp, List<String>>{
// Tests for https://github.com/flutter/flutter/issues/43383
Expand All @@ -267,6 +264,8 @@ dependencies {}
// section.
},
);
print('build.gradle contents:');
print(content);
}

Future<void> _genPubspecWithAllPlugins() async {
Expand Down
4 changes: 2 additions & 2 deletions script/tool/test/create_all_packages_app_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ android {
buildGradle,
containsAll(<Matcher>[
contains('This is the legacy file'),
contains('compileSdk flutter.compileSdkVersion'),
contains('compileSdk = 35'),
]));
});

Expand Down Expand Up @@ -375,7 +375,7 @@ android {
expect(
buildGradle,
containsAll(<Matcher>[
contains('compileSdk flutter.compileSdkVersion'),
contains('compileSdk = 35'),
contains('androidx.lifecycle:lifecycle-runtime'),
]));
});
Expand Down