Clean up stub methods

packages/camera/camera_avfoundation/example/ios/RunnerTests/MockCaptureDeviceController.h

@@ -79,10 +79,9 @@ NS_ASSUME_NONNULL_BEGIN
 @property(nonatomic, assign) float ISO;
 
 // Configuration Lock
-@property(nonatomic, assign) BOOL shouldFailConfiguration;
 /// Overrides the default implementation of locking device for configuration.
 /// @param error Error pointer to be set if lock fails
-@property(nonatomic, copy) void (^lockForConfigurationStub)(NSError **error);
+@property(nonatomic, copy) BOOL (^lockForConfigurationStub)(NSError **error);
 /// Overrides the default implementation of unlocking device configuration.
 @property(nonatomic, copy) void (^unlockForConfigurationStub)(void);
 
@@ -97,10 +96,9 @@ NS_ASSUME_NONNULL_BEGIN
 @property(nonatomic, copy) void (^setActiveVideoMaxFrameDurationStub)(CMTime duration);
 
 // Input Creation
-@property(nonatomic, strong) AVCaptureInput *inputToReturn;
 /// Overrides the default implementation of creating capture input.
 /// @param error Error pointer to be set if creation fails
-@property(nonatomic, copy) void (^createInputStub)(NSError **error);
+@property(nonatomic, copy) AVCaptureInput* (^createInputStub)(NSError **error);
 
 @end
 

packages/camera/camera_avfoundation/example/ios/RunnerTests/MockCaptureDeviceController.m

@@ -55,7 +55,6 @@ - (void)setExposureMode:(AVCaptureExposureMode)mode {
 }
 
 - (void)setExposurePointOfInterest:(CGPoint)point {
-  _exposurePointOfInterest = point;
   if (self.setExposurePointOfInterestStub) {
     self.setExposurePointOfInterestStub(point);
   }
@@ -75,14 +74,7 @@ - (void)setVideoZoomFactor:(float)factor {
 
 - (BOOL)lockForConfiguration:(NSError **)error {
   if (self.lockForConfigurationStub) {
-    self.lockForConfigurationStub(error);
-    return !self.shouldFailConfiguration;
-  }
-  if (self.shouldFailConfiguration) {
-    if (error) {
-      *error = [NSError errorWithDomain:@"test" code:0 userInfo:nil];
-    }
-    return NO;
+    return self.lockForConfigurationStub(error);
   }
   return YES;
 }
@@ -111,9 +103,9 @@ - (BOOL)isExposureModeSupported:(AVCaptureExposureMode)mode {
 
 - (AVCaptureInput *)createInput:(NSError *_Nullable *_Nullable)error {
   if (self.createInputStub) {
-    self.createInputStub(error);
+    return self.createInputStub(error);
   }
-  return self.inputToReturn;
+  return NULL;
 }
 
 @end