Skip to content

[flutter_svg] Implement errorBuilder callback #8364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 8 commits into from
Jan 9, 2025
Merged

[flutter_svg] Implement errorBuilder callback #8364

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b3fb8ad
Implement errorBuilder callback
memishood Jan 2, 2025
1d0e588
Merge branch 'main' into feature/flutter-svg-error-builder
domesticmouse Jan 3, 2025
d07238f
Merge branch 'main' into feature/flutter-svg-error-builder
memishood Jan 6, 2025
766979e
Add widget tests for errorBuilder
memishood Jan 6, 2025
c4a4b4d
Merge branch 'main' into feature/flutter-svg-error-builder
domesticmouse Jan 6, 2025
3c154b3
Merge branch 'main' into feature/flutter-svg-error-builder
memishood Jan 8, 2025
8afb9b4
Set the file path to nosuchfile in the widget test
memishood Jan 8, 2025
39e2bfa
Merge branch 'main' into feature/flutter-svg-error-builder
memishood Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add widget tests for errorBuilder
  • Loading branch information
@memishood
memishood committed Jan 6, 2025
commit 766979ebeedddbd14c374b02d3636c4307576f47
102 changes: 102 additions & 0 deletions third_party/packages/flutter_svg/test/widget_svg_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'dart:convert';
import 'dart:io';

import 'package:flutter/foundation.dart';
import 'package:flutter/widgets.dart';
Expand Down Expand Up @@ -767,6 +768,107 @@ void main() {
widgetFinder, matchesGoldenFile('golden_widget/image_$key.png'));
}
});

group('SvgPicture - errorBuilder', () {
testWidgets('SvgPicture.string handles failure',
(WidgetTester tester) async {
await tester.pumpWidget(
MediaQuery(
data: mediaQueryData,
child: SvgPicture.string(
'<!-- invalid svg -->',
errorBuilder: (
BuildContext context,
Object error,
StackTrace stackTrace,
) {
return const Directionality(
textDirection: TextDirection.ltr,
child: Text('image failed'),
);
},
),
),
);
await tester.pumpAndSettle();

expect(find.text('image failed'), findsOneWidget);
});

testWidgets('SvgPicture.memory handles failure',
(WidgetTester tester) async {
await tester.pumpWidget(
MediaQuery(
data: mediaQueryData,
child: SvgPicture.memory(
Uint8List.fromList(utf8.encode('<!-- invalid svg -->')),
errorBuilder: (
BuildContext context,
Object error,
StackTrace stackTrace,
) {
return const Directionality(
textDirection: TextDirection.ltr,
child: Text('image failed'),
);
},
),
),
);
await tester.pumpAndSettle();

expect(find.text('image failed'), findsOneWidget);
});

testWidgets('SvgPicture.asset handles failure',
(WidgetTester tester) async {
await tester.pumpWidget(
MediaQuery(
data: mediaQueryData,
child: SvgPicture.asset(
'/wrong path',
errorBuilder: (
BuildContext context,
Object error,
StackTrace stackTrace,
) {
return const Directionality(
textDirection: TextDirection.ltr,
child: Text('image failed'),
);
},
),
),
);
await tester.pumpAndSettle();

expect(find.text('image failed'), findsOneWidget);
});

testWidgets('SvgPicture.file handles failure', (WidgetTester tester) async {
await tester.pumpWidget(
MediaQuery(
data: mediaQueryData,
child: SvgPicture.file(
File(''),
errorBuilder: (
BuildContext context,
Object error,
StackTrace stackTrace,
) {
return const Directionality(
textDirection: TextDirection.ltr,
child: Text('image failed'),
);
},
),
),
);
await tester.pumpAndSettle();

expect(find.text('image failed'), findsOneWidget);
});
});
}

class FakeAssetBundle extends Fake implements AssetBundle {
Expand Down
Loading