Skip to content

[vector_graphics] Fix memory leaks and activate leak testing [prod-leak-fix] #8373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Jan 28, 2025
Merged

[vector_graphics] Fix memory leaks and activate leak testing [prod-leak-fix] #8373

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e6789c8
fix memory leaks
ValentinVignal Jan 6, 2025
5c997e1
Activate leak testing
ValentinVignal Jan 6, 2025
cce339e
Fix the tests
ValentinVignal Jan 6, 2025
08792f3
Update version number
ValentinVignal Jan 6, 2025
86fc536
Store and dispose ImageInfo
ValentinVignal Jan 28, 2025
f1a0d21
More description changelog
ValentinVignal Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the tests
  • Loading branch information
@ValentinVignal
ValentinVignal committed Jan 18, 2025
commit cce339e983eb4cc15f0384a4b6eb2e9e36a041fb
10 changes: 7 additions & 3 deletions packages/vector_graphics/test/vector_graphics_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,9 @@ void main() {
);
await tester.pumpAndSettle();

expect(await completer.future, isA<PictureInfo>());
final PictureInfo picture = await completer.future;
addTearDown(picture.picture.dispose);
expect(picture, isA<PictureInfo>());
expect(debugLastLocale, const Locale('fr', 'CH'));
expect(debugLastTextDirection, TextDirection.rtl);
});
Expand Down Expand Up @@ -475,7 +477,9 @@ void main() {
);
await tester.pumpAndSettle();

expect(await completer.future, isA<PictureInfo>());
final PictureInfo picture = await completer.future;
addTearDown(picture.picture.dispose);
expect(picture, isA<PictureInfo>());
expect(debugLastLocale, PlatformDispatcher.instance.locale);
expect(debugLastTextDirection, TextDirection.ltr);
});
Expand Down Expand Up @@ -584,7 +588,7 @@ void main() {
expect(imageCache.statusForKey(imageKey).live, false);
expect(imageCache.statusForKey(imageKey).keepAlive, true);

// A blue square, becuase the image is available now.
// A blue square, because the image is available now.
await expectLater(
find.byKey(key),
matchesGoldenFile('vg_with_image_blue.png'),
Expand Down