Skip to content

[url_launcher] When not fully loaded, clicking close causes the callback to not be triggered correctly. #8582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 15 commits into from
Apr 1, 2025
Merged

[url_launcher] When not fully loaded, clicking close causes the callback to not be triggered correctly. #8582

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3403990
fix(url_launcher): When not fully loaded, clicking close causes the c…
StanleyCocos Feb 7, 2025
6082e8c
fix: change log
StanleyCocos Feb 7, 2025
13e3058
fix: format
StanleyCocos Feb 7, 2025
87a4a3a
fix: chenge log
StanleyCocos Feb 7, 2025
940b311
fix: test
StanleyCocos Feb 7, 2025
4f733e5
fix: type
StanleyCocos Feb 8, 2025
2c0d46b
fix: test
StanleyCocos Feb 10, 2025
4c258ab
Merge branch 'main' into fix/url_launcher_ios
StanleyCocos Feb 10, 2025
2a095f2
fix: changelog
StanleyCocos Feb 13, 2025
39ef600
Merge branch 'main' into fix/url_launcher_ios
StanleyCocos Feb 13, 2025
99359e7
fix: comment
StanleyCocos Feb 18, 2025
a2c8559
fix: comment
StanleyCocos Feb 21, 2025
1b53da5
Merge branch 'main' into fix/url_launcher_ios
StanleyCocos Feb 21, 2025
68e865a
Merge branch 'main' into fix/url_launcher_ios
StanleyCocos Mar 17, 2025
5e7b70e
add dismissed
StanleyCocos Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: format
  • Loading branch information
@StanleyCocos
StanleyCocos committed Feb 7, 2025
commit 13e30582fe066fe7adb8d295b23b096078ff66cf
2 changes: 1 addition & 1 deletion ...her/url_launcher_ios/ios/url_launcher_ios/Sources/url_launcher_ios/URLLaunchSession.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ final class URLLaunchSession: NSObject, SFSafariViewControllerDelegate {
} else {
completion(.success(.failedToLoad))
}
isLoadCompleted = didLoadSuccessfully;
isLoadCompleted = didLoadSuccessfully
}

/// Called when the user finishes using the Safari view controller.
Expand Down