Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f476931
Add bridging header file
FirentisTFW Feb 7, 2025
b0decfb
Migrate CameraPreviewPauseTests to Swift
FirentisTFW Feb 7, 2025
75dca24
Migrate CameraPropertiesTests to Swift, format code
FirentisTFW Feb 10, 2025
4a98112
Migrate QueueUtilsTests to Swift
FirentisTFW Feb 10, 2025
2a4168c
Migrate CameraExposureTests to Swift
FirentisTFW Feb 10, 2025
164095e
Migrate CameraFocusTests and AvailableCamerasTest to Swift
FirentisTFW Feb 10, 2025
ef0c0c0
Migrate CameraPermissionTests to Swift
FirentisTFW Feb 10, 2025
aab1d5e
Format file
FirentisTFW Feb 11, 2025
06a7bd6
Bump version and update changelog
FirentisTFW Feb 11, 2025
cb937d6
Format Swift files
FirentisTFW Feb 11, 2025
8d10061
Handle catching Objective-C errors in Swift tests
FirentisTFW Feb 11, 2025
a314c5b
Fix expectation timeout after rebase
FirentisTFW Feb 11, 2025
6d4bf8d
Remove redundant comments
FirentisTFW Feb 11, 2025
fc34006
Add more context to changelog entry
FirentisTFW Feb 11, 2025
2f7c9fd
Refactor code according to style guide
FirentisTFW Feb 11, 2025
8701be9
Start changelog message with a verb
FirentisTFW Feb 11, 2025
85ef5a1
Make method private
FirentisTFW Feb 12, 2025
5ba3781
Compare CGPoints directly
FirentisTFW Feb 12, 2025
cacdf4c
Make helper class fileprivate
FirentisTFW Feb 12, 2025
7c589d1
Do not use setUp for a file with only two tests
FirentisTFW Feb 12, 2025
605b4df
Remove shared state from tests
FirentisTFW Feb 12, 2025
1453630
Remove redundant empty lines
FirentisTFW Feb 12, 2025
4f9cbdd
Add a todo to use errors when migrating to Swift
FirentisTFW Feb 12, 2025
a10c4ac
Format files
FirentisTFW Feb 12, 2025
20682dc
Add more information to a todo
FirentisTFW Feb 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add more information to a todo
  • Loading branch information
FirentisTFW committed Feb 12, 2025
commit 20682dc108d9fac5c28bddebd18bd81244db86dc
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// found in the LICENSE file.

// TODO(FirentisTFW): Remove this file when the plugin code that uses it is migrated to Swift.
// After the migration, the code should throw Swift errors instead of Objective-C exceptions, thus
// this file will not be needed.

#import <Foundation/Foundation.h>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ AVCaptureFlashMode FCPGetAVCaptureFlashModeForPigeonFlashMode(FCPPlatformFlashMo
case FCPPlatformFlashModeAlways:
return AVCaptureFlashModeOn;
case FCPPlatformFlashModeTorch:
// TODO(FirentisTFW): Throw an error when migrating to Swift.
NSCAssert(false, @"This mode cannot be converted, and requires custom handling.");
return -1;
}
Expand Down