Skip to content

[webview_flutter] fix: Fixed handling of null authentication challeng… #8619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msamoeed wants to merge 1 commit into from
Closed

[webview_flutter] fix: Fixed handling of null authentication challeng… #8619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[webview_flutter] fix: Fixed handling of null authentication challeng… 
…e responses to follow WKWebView's default behavior, When no authentication challenge handler is implemented in Flutter, return the default WKWebView cancel response instead of throwing an error. This makes the behavior more idiomatic and prevents crashes

When no authentication challenge handler is implemented in Flutter,
return the default WKWebView cancel response instead of throwing an error.

Fixes flutter/flutter#163213
  • Loading branch information
@msamoeed
msamoeed committed Feb 13, 2025
commit 84d2cc20f38705c778e01fd7d9b50c9eeec63578
2 changes: 1 addition & 1 deletion .../darwin/webview_flutter_wkwebview/Sources/webview_flutter_wkwebview/WebKitLibrary.g.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4344,7 +4344,7 @@ final class PigeonApiWKNavigationDelegate: PigeonApiProtocolWKNavigationDelegate
let message: String? = nilOrValue(listResponse[1])
let details: String? = nilOrValue(listResponse[2])
completion(.failure(PigeonError(code: code, message: message, details: details)))
} else if listResponse[0] == nil {
} else if listResponse[0] == nil || firstElement is NSNull {
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for reference in case you plan to contribute to webview_flutter in the future: Per the comment at the top of this file, it cannot be edited like this.

// Autogenerated from Pigeon (v22.7.2), do not edit directly.

completion(
.failure(
PigeonError(
Expand Down