Skip to content

[pigeon] Update task queue handling #8627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 10 commits into from
Feb 15, 2025
Merged

[pigeon] Update task queue handling #8627

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2d60a20
Add integration tests, remove background_platform_channels.dart
stuartmorgan-g Jan 31, 2025
709a20d
Fix Obj-C, implement Swift
stuartmorgan-g Feb 3, 2025
be83e5f
Fix Java and Kotlin
stuartmorgan-g Feb 4, 2025
72e2b6f
Version bump
stuartmorgan-g Feb 13, 2025
7a2aceb
Move TaskQueueType to its own file
stuartmorgan-g Feb 14, 2025
293789b
Fix Kotlin tests
stuartmorgan-g Feb 14, 2025
f09630f
Windows fixes
stuartmorgan-g Feb 14, 2025
3e4320c
Remove duplicate line
stuartmorgan-g Feb 14, 2025
46388df
Missing Windows include
stuartmorgan-g Feb 14, 2025
551066e
Linux fixes
stuartmorgan-g Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Linux fixes
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g authored Feb 15, 2025
commit 551066e4f45920b263bbaa1e6dcaaaf2450c1674
6 changes: 3 additions & 3 deletions packages/pigeon/platform_tests/test_plugin/linux/test_plugin.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ struct _TestPlugin {

GCancellable* cancellable;

int main_thread_id;
std::thread::id main_thread_id;
};

G_DEFINE_TYPE(TestPlugin, test_plugin, G_TYPE_OBJECT)
Expand Down Expand Up @@ -796,14 +796,14 @@ static CoreTestsPigeonTestHostIntegrationCoreApiDefaultIsMainThreadResponse*
default_is_main_thread(gpointer user_data) {
TestPlugin* self = TEST_PLUGIN(user_data);
return core_tests_pigeon_test_host_integration_core_api_default_is_main_thread_response_new(
std::this_thread::get_id() == this->main_thread_id);
std::this_thread::get_id() == self->main_thread_id);
}

static CoreTestsPigeonTestHostIntegrationCoreApiTaskQueueIsBackgroundThreadResponse*
task_queue_is_background_thread(gpointer user_data) {
TestPlugin* self = TEST_PLUGIN(user_data);
return core_tests_pigeon_test_host_integration_core_api_task_queue_is_background_thread_response_new(
std::this_thread::get_id() != this->main_thread_id);
std::this_thread::get_id() != self->main_thread_id);
}

static void noop_cb(GObject* object, GAsyncResult* result, gpointer user_data) {
Expand Down