Skip to content

[camera_android_camerax] Fix 90°-off preview rotation #8629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 20 commits into from
Feb 26, 2025
Merged

[camera_android_camerax] Fix 90°-off preview rotation #8629

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f02e872
Minimal device orientation preview fixes maybe.
matanlurey Feb 11, 2025
f90ede6
hooked up handlesCropAndRotation, attempted fix for deducting preappl…
camsim99 Feb 11, 2025
a87423f
add print for debugging if needed, probs not i think my emulator is j…
camsim99 Feb 11, 2025
5afdc1d
++
matanlurey Feb 13, 2025
f1009fd
fix me fixmes
camsim99 Feb 14, 2025
7ed88d7
Review + add tests
camsim99 Feb 17, 2025
ec557cf
bump version
camsim99 Feb 17, 2025
7d0df1e
nit
camsim99 Feb 19, 2025
547dc69
format
camsim99 Feb 19, 2025
d1db8a0
easy fixes
camsim99 Feb 20, 2025
04b2721
refactor tests
camsim99 Feb 20, 2025
49731d2
actually add my refactored file
camsim99 Feb 20, 2025
6e0e18e
nit + beef up tests
camsim99 Feb 20, 2025
6d5d4f6
add missing return hehe
camsim99 Feb 21, 2025
313b51c
nice to haves
camsim99 Feb 21, 2025
d693cc7
nits
camsim99 Feb 21, 2025
f437b05
address review and rewrite tests again
camsim99 Feb 23, 2025
2d74cc0
nits
camsim99 Feb 24, 2025
3bfcc54
Rename function for clarity
camsim99 Feb 24, 2025
850fbe3
oops
camsim99 Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit
  • Loading branch information
@camsim99
camsim99 committed Feb 19, 2025
commit 7d0df1edc54ca2608996368fd40d491e88fff5fb
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ class AndroidCameraCameraX extends CameraPlatform {
@visibleForTesting
late double sensorOrientationDegrees;

/// Whether or not the Android Surface producer automatically handles
/// Whether or not the Android surface producer automatically handles
/// correcting the rotation of camera previews for the device this plugin runs on.
@visibleForTesting
Copy link
Contributor

@matanlurey matanlurey Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try to not inspect the internal state of these variables as the test (in other words, not make them @visibleForTesting and make them private instead), and instead inspect the output of the widget tree. I'll leave more comments on the test itself.

Copy link
Contributor Author

@camsim99 camsim99 Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left these as visible so that we can set them directly in the preview_rotation_test.dart. These values being fetched as expected is tested in android_camera_camerax_test.dart.

Copy link
Contributor

@matanlurey matanlurey Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left these as visible so that we can set them directly in the preview_rotation_test.dart.

Is it possible to write that test without setting these variables directly? By setting them directly, we are bypassing the logic that is initially used to set them (in createCameraWithSettings) which if I remember correctly was a significant source of difficulty.

late bool handlesCropAndRotation;
Expand Down