Skip to content

[video_player] Fix layout issue caused by Transform.rotate not affecting space calculation. #8685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 14 commits into from
Mar 27, 2025
+23 −25
Merged

[video_player] Fix layout issue caused by Transform.rotate not affecting space calculation. #8685

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
00cdd54
[video_player] using RotatedBox
fa0311 Feb 24, 2025
96b33d9
[video_player] update test
fa0311 Feb 26, 2025
9de259b
Merge branch 'main' into use-rotated-box
fa0311 Feb 26, 2025
960f01c
[video_player] update version
fa0311 Feb 26, 2025
5d9b87d
Merge branch 'main' into use-rotated-box
fa0311 Mar 8, 2025
6be9577
[video_player] add assertion for rotation to be a multiple of 90
fa0311 Mar 13, 2025
5a4ec4f
Merge branch 'main' into use-rotated-box
fa0311 Mar 13, 2025
4bea0c6
[video_player] fix test
fa0311 Mar 15, 2025
b11717b
[video_player] add assertion for rotation to be a multiple of 90
fa0311 Mar 20, 2025
c5131a3
Merge branch 'main' into use-rotated-box
fa0311 Mar 20, 2025
5ac9565
[video_player] add assertion for rotation to be a multiple of 90
fa0311 Mar 20, 2025
74062cd
[video_player] update CHANGLOG
fa0311 Mar 20, 2025
aebd6c4
[video_player] update version
fa0311 Mar 26, 2025
6da73c9
Merge branch 'main' into use-rotated-box
fa0311 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[video_player] add assertion for rotation to be a multiple of 90 
Signed-off-by: ふぁ <[email protected]>
  • Loading branch information
@fa0311
fa0311 committed Mar 20, 2025
commit b11717beb9831c9b4cf8867ecee1469a04fbebde
6 changes: 4 additions & 2 deletions packages/video_player/video_player/lib/video_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,10 +888,12 @@ class _VideoPlayerWithRotation extends StatelessWidget {

@override
Widget build(BuildContext context) {
assert(rotation % 90 == 0, 'Rotation must be a multiple of 90');
if (rotation % 90 != 0 || rotation == 0) {
if (rotation == 0) {
return child;
}
if (rotation % 90 != 0) {
throw ArgumentError('Rotation must be a multiple of 90');
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An argument error should be thrown at the point where it is passed as an argument, which is the constructor on line 884.

Copy link
Contributor Author

@fa0311 fa0311 Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue has been fixed.

}
return RotatedBox(
quarterTurns: rotation ~/ 90,
child: child,
Expand Down