[google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry #8754
Run update-release-info
- Loading branch information
commit 4463f5dc201404c1c9cad4c612ed1d17b090a0c6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| ## 2.10.2 | ||
|
|
||
| * Fixes typos in README and CHANGELOG. | ||
|
|
||
| ## 2.10.1 | ||
|
|
||
| * Updates READMEs and API docs. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the typo is only in the README. There is no CHANGELOG fix in this package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I just ran
dart run script/tool/bin/flutter_plugin_tools.dart update-release-info --version=minimal --base-branch=upstream/main --changelog="Fixes typos in README and CHANGELOG."I expected the change message to be put in both packages that were modified. I'm guessing theupdate-release-infotool is smarter and it ignores CHANGELOG changes?Do you want me to:
a) Force an update to
google_maps_flutter_platform_interface, orb) Merely change "Fixes typos in README and CHANGELOG" above to "Fixes typo in README"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct.
This one. The trivial issue in the other CHANGELOG will be cleaned up on the next publish, and isn't worth releasing a new version for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, and thanks for your patience with me. Change pushed now.