-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[webview_flutter_wkwebview] Fixes crash when sending undefined message via javascript channel #8776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 12 commits into
flutter:main
from
LinXunFeng:fix_crash_when_send_undefined
Mar 31, 2025
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6abb674
Fixes crash when sending undefined message via javascript channel
LinXunFeng 2de63f3
Merge branch 'main' into fix_crash_when_send_undefined
LinXunFeng 0905d5e
Merge branch 'main' of github.com:flutter/packages into fix_crash_whe…
bparrishMines 153a85c
javascript spelling
bparrishMines 1362056
Preserve undefined and null output
LinXunFeng 5c7801b
Code formatting
LinXunFeng 83b1aed
update
LinXunFeng feb84e2
Revert "update"
LinXunFeng 77bec50
Revert "Code formatting"
LinXunFeng db6b43a
Revert "Preserve undefined and null output"
LinXunFeng ef6ccae
Return '(null)' when message.body is null
LinXunFeng 4bde9bc
Remove unnecessary symbols
LinXunFeng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Return '(null)' when message.body is null
- Loading branch information
commit ef6ccae30679874f210812532d5ac4d61a7bb556
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
!shouldn't be needed here, for the same reason.