Skip to content

[pigeon] kotlin equality methods #8887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Mar 25, 2025
Merged

[pigeon] kotlin equality methods #8887

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
84d0886
add kotlin equality and tests
tarrinneal Mar 20, 2025
8613ea9
add more scenarios to write deepEquals
tarrinneal Mar 20, 2025
2dabedb
fix logic on dart deep equals utility
tarrinneal Mar 20, 2025
b10a464
Merge branch 'main' of github.com:flutter/packages into more-equal
tarrinneal Mar 24, 2025
48fa349
update Internal options naming and extension
tarrinneal Mar 24, 2025
be3ca11
general use method
tarrinneal Mar 24, 2025
d7dc94c
nits
tarrinneal Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add more scenarios to write deepEquals
  • Loading branch information
@tarrinneal
tarrinneal committed Mar 20, 2025
commit 8613ea98385a8c3d191db17913d3f699a2d99e03
5 changes: 3 additions & 2 deletions packages/pigeon/lib/src/kotlin/kotlin_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,8 +1308,9 @@ private fun deepEquals${generatorOptions.fileSpecificClassNameComponent}(a: Any?
if (root.classes.isNotEmpty &&
root.classes.any((Class dataClass) => dataClass.fields.any(
(NamedType field) =>
field.type.baseName.startsWith('List') ||
field.type.baseName.startsWith('Map')))) {
_kotlinTypeForBuiltinDartType(field.type) != null &&
(field.type.baseName.contains('List') ||
field.type.baseName.startsWith('Map'))))) {
_writeDeepEquals(generatorOptions, indent);
}
}
Expand Down