Skip to content

[multicast_dns] MDnsClient::listen supports onError callback #8888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Apr 2, 2025
Merged

[multicast_dns] MDnsClient::listen supports onError callback #8888

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52d7a4c
[multicast_dns] MDnsClient::listen supports onError callback (#8888)
alexander-irion Mar 19, 2025
82aa495
Adjust CHANGELOG wording
stuartmorgan-g Apr 1, 2025
27cdff3
Change version and adapt comment
alexander-irion Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change version and adapt comment 
- Change version to 0.3.3
- Adapt comment about new parameter
  • Loading branch information
@alexander-irion
alexander-irion committed Apr 2, 2025
commit 27cdff35d4a14fb2fc7d773e0cae86aceb4c20c6
2 changes: 1 addition & 1 deletion packages/multicast_dns/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 0.3.2+9
## 0.3.3

* Adds an optional error callback for `MDnsClient::start` to prevent uncaught exceptions.

Expand Down
8 changes: 3 additions & 5 deletions packages/multicast_dns/lib/multicast_dns.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,9 @@ class MDnsClient {
/// for the mDNS query. If not provided, defaults to either `224.0.0.251` or
/// or `FF02::FB`.
///
/// The [onError] function allows to provide a callback function, called in
/// case of a stream error. If omitted any errors on the stream are considered
/// unhandled, and will be passed to the current [Zone]'s error handler. By
/// default unhandled async errors are treated as if they were uncaught top-level
/// errors.
/// If provided, [onError] will be called in case of a stream error. If
/// omitted any errors on the stream are considered unhandled, and will be
/// passed to the current [Zone]'s error handler.
///
/// Subsequent calls to this method are ignored while the mDNS client is in
/// started state.
Expand Down
2 changes: 1 addition & 1 deletion packages/multicast_dns/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: multicast_dns
description: Dart package for performing mDNS queries (e.g. Bonjour, Avahi).
repository: https://github.com/flutter/packages/tree/main/packages/multicast_dns
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+multicast_dns%22
version: 0.3.2+9
version: 0.3.3

environment:
sdk: ^3.4.0
Expand Down