-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[go_router_builder]: Fix Parameter generates a warning #8889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
083973d
allow parse Enum with nullable String
CaoGiaHieu-dev b50c1b2
bump and update change log
CaoGiaHieu-dev 454b269
reformat
CaoGiaHieu-dev 456d6c1
reformat
CaoGiaHieu-dev ba31e42
Merge branch 'main' into main
CaoGiaHieu-dev 4fdc26a
update
CaoGiaHieu-dev 13bdc00
update
CaoGiaHieu-dev 6281ddd
update test
CaoGiaHieu-dev d220bd8
update
CaoGiaHieu-dev 31ae729
fix suffix
CaoGiaHieu-dev 5cb1f71
Merge branch 'main' into main
CaoGiaHieu-dev 877c5fb
Merge branch 'main' into main
CaoGiaHieu-dev 24f5301
Update CHANGELOG.md
CaoGiaHieu-dev 11338d8
Merge branch 'main' into main
CaoGiaHieu-dev 6b23b9d
Merge branch 'main' into main
CaoGiaHieu-dev c59d3e9
Merge branch 'flutter:main' into main
CaoGiaHieu-dev e9180dc
fix warning
CaoGiaHieu-dev aad960c
fix
CaoGiaHieu-dev c9dcab4
fix
CaoGiaHieu-dev fb94d91
fix gen lints
CaoGiaHieu-dev 689c8cb
update
CaoGiaHieu-dev eaf2023
update change log
CaoGiaHieu-dev 1461d76
Update CHANGELOG.md
CaoGiaHieu-dev d9fa7fc
Merge branch 'main' into main
CaoGiaHieu-dev 1cd9202
Merge branch 'main' into main
CaoGiaHieu-dev ce7e829
Update pubspec.yaml
CaoGiaHieu-dev a0e602e
Merge branch 'main' into main
CaoGiaHieu-dev aa41975
Merge branch 'main' into main
CaoGiaHieu-dev 84ce9ac
Merge branch 'main' into main
CaoGiaHieu-dev b4830ea
Merge branch 'main' into main
CaoGiaHieu-dev a572081
Merge branch 'main' into main
CaoGiaHieu-dev 34d6bf3
Update type_helpers.dart
CaoGiaHieu-dev fbc2b8e
Update type_helpers.dart
CaoGiaHieu-dev db90f8b
Merge branch 'main' into main
CaoGiaHieu-dev a9a574c
Merge branch 'main' into main
CaoGiaHieu-dev a85e984
Merge branch 'main' into main
CaoGiaHieu-dev 1c8c848
Merge branch 'main' into main
CaoGiaHieu-dev 871a2d2
Update pubspec.yaml
CaoGiaHieu-dev 685b8e8
Merge branch 'main' into main
CaoGiaHieu-dev 50c4e78
Merge branch 'main' into main
CaoGiaHieu-dev 960fd08
Merge branch 'main' into main
CaoGiaHieu-dev 06a0d59
Merge branch 'main' into main
CaoGiaHieu-dev d1a7c75
Merge branch 'main' into main
CaoGiaHieu-dev 4b79fe6
update
CaoGiaHieu-dev 992a897
update
CaoGiaHieu-dev d0bbc51
bump
CaoGiaHieu-dev c0fb4cb
update
CaoGiaHieu-dev e7222c4
update
CaoGiaHieu-dev d7ffa9e
Merge branch 'main' into main
CaoGiaHieu-dev 6b77867
Merge branch 'main' into main
CaoGiaHieu-dev 2d4a5cc
Merge branch 'main' into CaoGiaHieu-dev/main
CaoGiaHieu-dev 8b41333
Merge branch 'main' into main
CaoGiaHieu-dev 2f59d48
Merge branch 'main' into main
CaoGiaHieu-dev 6feaa64
fix
CaoGiaHieu-dev 46923f3
Merge branch 'main' into main
CaoGiaHieu-dev b6942a8
Merge branch 'main' into main
CaoGiaHieu-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'main' into main
- Loading branch information
commit d1a7c75ea211129de7e63d4bcb487e5b465e8add
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is possible to avoid the above in
Nextbecause that code is already landed and present. I think the path forward here is to include it as a bullet point under 3.0.2 and remove Next.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was related to this issue flutter/flutter#170832 . it wasnt landed yet .
BTW if my pr cannot merge so i will check again after it fixed