Skip to content

[camera_android] Don't override default fps range when not recording #8891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 10 commits into from
Mar 31, 2025
Merged

[camera_android] Don't override default fps range when not recording #8891

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
67f25b5
Set camera feature range when recording
davidmartos96 Mar 19, 2025
a159e2e
Merge branch 'fix_fps' into fix_fps_latest
davidmartos96 Mar 19, 2025
9086381
update tests
davidmartos96 Mar 19, 2025
0452839
format
davidmartos96 Mar 20, 2025
da5281b
rename method
davidmartos96 Mar 20, 2025
983cda3
bump version
davidmartos96 Mar 20, 2025
79cb4e7
format
davidmartos96 Mar 20, 2025
3fea37a
update changelog
davidmartos96 Mar 24, 2025
e68f97b
Merge branch 'main' into fix_fps_latest
davidmartos96 Mar 27, 2025
d1c8a65
Merge branch 'main' into fix_fps_latest
davidmartos96 Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bump version
  • Loading branch information
@davidmartos96
davidmartos96 committed Mar 20, 2025
commit 983cda3e1665e7033ce8a224780367dae0435b72
4 changes: 4 additions & 0 deletions packages/camera/camera_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.10.10+2

* Don't set the FPS range unless video recording. It can cause dark image previews on some devices becuse the auto exposure algorithm is more constrained after fixing a min & max FPS value.
Copy link
Contributor

@reidbaker reidbaker Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this description to include the behavior change to users of this plugin that rely on the defaults? (even if that is no impact)

Copy link
Contributor Author

@davidmartos96 davidmartos96 Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reidbaker Would this be more clear?

Don't set the FPS range unless video recording. It can cause dark image previews on some devices becuse the auto exposure algorithm is more constrained after fixing the min/max FPS range to the same value. This change has the side effect that providing the fps parameter will not affect the camera preview when not video recording. And if you need a lower frame rate in your image streaming handler, you can skip frames by checking the time it passed since the last frame.

Copy link
Contributor

@reidbaker reidbaker Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great.


## 0.10.10+1

* Updates compileSdk 34 to flutter.compileSdkVersion.
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Android implementation of the camera plugin.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22

version: 0.10.10+1
version: 0.10.10+2

environment:
sdk: ^3.6.0
Expand Down