Skip to content

[camera_avfoundation] Test utils and mocks swift migration - part 3 #8912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Mar 28, 2025
Merged

[camera_avfoundation] Test utils and mocks swift migration - part 3 #8912

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37f1cf8
Migrate MockAssetWriter, MockAssetWriterInput, and MockAssetWriterInp…
RobertOdrowaz Mar 16, 2025
e1d1c32
Migrate MockCaptureDevice, MockCaptureInput, and MockCaptureDeviceInp…
RobertOdrowaz Mar 16, 2025
3625645
Replace fatalError with preconditionFailure for unimplemented mock pr…
RobertOdrowaz Mar 27, 2025
1990598
Remove unnecessary explicit types
RobertOdrowaz Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unnecessary explicit types
  • Loading branch information
@RobertOdrowaz
RobertOdrowaz committed Mar 28, 2025
commit 199059879525bc3b4017ca6dd77903fc53af962a
2 changes: 1 addition & 1 deletion packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockAssetWriter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ final class MockAssetWriter: NSObject, FLTAssetWriter {
var finishWritingStub: ((() -> Void) -> Void)?

var status: AVAssetWriter.Status {
return statusStub?() ?? AVAssetWriter.Status.unknown
return statusStub?() ?? .unknown
}

var error: Error? = nil
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockCaptureDevice.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class MockCaptureDevice: NSObject, FLTCaptureDevice {
var isTorchAvailable = false
var torchMode: AVCaptureDevice.TorchMode {
get {
getTorchModeStub?() ?? AVCaptureDevice.TorchMode.off
getTorchModeStub?() ?? .off
}
set {
setTorchModeStub?(newValue)
Expand Down