Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/video_player/video_player_web/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT
## 2.4.0

* Adds HTML5 video poster support as a VideoPlayerWebOptions.
* Updates minimum supported SDK version to Flutter 3.27/Dart 3.6.

## 2.3.5
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,78 @@ void main() {
});
});

group('poster', () {
testWidgets('when null expect no poster attribute',
(WidgetTester tester) async {
await player.setOptions(
const VideoPlayerWebOptions(),
);

expect(video.poster, isEmpty);
expect(video.getAttribute('poster'), isNull);
});

testWidgets('when provided expect poster attribute set',
(WidgetTester tester) async {
final Uri posterUri = Uri.parse('https://example.com/poster.jpg');
await player.setOptions(
VideoPlayerWebOptions(
poster: posterUri,
),
);

expect(video.poster, posterUri.toString());
expect(video.getAttribute('poster'), posterUri.toString());
});

testWidgets('when set to null after having value expect poster removed',
(WidgetTester tester) async {
final Uri posterUri = Uri.parse('https://example.com/poster.jpg');

await player.setOptions(
VideoPlayerWebOptions(
poster: posterUri,
),
);

expect(video.poster, posterUri.toString());

await player.setOptions(
const VideoPlayerWebOptions(),
);

expect(video.poster, isEmpty);
expect(video.getAttribute('poster'), isNull);
});

testWidgets('when updated expect poster attribute updated',
(WidgetTester tester) async {
final Uri initialPoster =
Uri.parse('https://example.com/poster1.jpg');
final Uri updatedPoster =
Uri.parse('https://example.com/poster2.jpg');

// Set initial poster
await player.setOptions(
VideoPlayerWebOptions(
poster: initialPoster,
),
);

expect(video.poster, initialPoster.toString());

// Update poster
await player.setOptions(
VideoPlayerWebOptions(
poster: updatedPoster,
),
);

expect(video.poster, updatedPoster.toString());
expect(video.getAttribute('poster'), updatedPoster.toString());
});
});

group('when called first time', () {
testWidgets('expect correct options', (WidgetTester tester) async {
await player.setOptions(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,10 @@ class VideoPlayer {
if (!options.allowRemotePlayback) {
_videoElement.disableRemotePlayback = true;
}

if (options.poster != null) {
_videoElement.poster = options.poster!.toString();
}
}

void _resetOptions() {
Expand All @@ -273,6 +277,7 @@ class VideoPlayer {
_onContextMenu = null;
}
_videoElement.removeAttribute('disableRemotePlayback');
_videoElement.removeAttribute('poster');
}

/// Disposes of the current [web.HTMLVideoElement].
Expand Down
4 changes: 2 additions & 2 deletions packages/video_player/video_player_web/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_web
description: Web platform implementation of video_player.
repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player_web
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.3.5
version: 2.4.0

environment:
sdk: ^3.6.0
Expand All @@ -21,7 +21,7 @@ dependencies:
sdk: flutter
flutter_web_plugins:
sdk: flutter
video_player_platform_interface: ^6.3.0
video_player_platform_interface: ^6.4.0
web: ">=0.5.1 <2.0.0"

dev_dependencies:
Expand Down